Conversation
…ade as TcpObject Fixes #968
…l/ApplicationPattern into PrathibaJee/issue968
PrathibaJee
requested review from
DanaSunal,
IswaryaaS,
MartinSunal and
vanithavalluripalli9
as code owners
| * @returns {String} | ||
| **/ | ||
| static async getServerLtpListAsync(ltpUuid) { | ||
| let ltp = await controlConstruct.getLogicalTerminationPointAsync(ltpUuid); |
There was a problem hiding this comment.
here, in documentation i think "return" value is a "List" instead of String
There was a problem hiding this comment.
Modified the documentation accordingly.Thanks.
.../applicationPattern/onfModel/services/models/logicalTerminationPoint/ConfigurationInputV2.js
Outdated
Show resolved
Hide resolved
| @@ -4,7 +4,7 @@ | |||
| const LogicalTerminationPoint = require('onf-core-model-ap/applicationPattern/onfModel/models/LogicalTerminationPoint'); | |||
| const LogicalTerminationPointConfigurationInput = require('onf-core-model-ap/applicationPattern/onfModel/services/models/logicalTerminationPoint/ConfigurationInput'); | |||
There was a problem hiding this comment.
I think this shall also be updated as ConfigurationInputV2.js and corresponding implementation could be updated accordingly.
There was a problem hiding this comment.
Thank you, removed the ConfigurationInput declaration as in the latest we are not using that module.
|
|
||
| const integerProfile = require('onf-core-model-ap/applicationPattern/onfModel/models/profile/IntegerProfile'); | ||
| const integerProfile = require('onf-core-model-ap/applicationPattern/onfModel/models/profile/IntegerProfile'); | ||
| const HttpClientInterface = require('onf-core-model-ap/applicationPattern/onfModel/models/layerProtocols/HttpClientInterface'); |
There was a problem hiding this comment.
I can see a duplicity in import of httpClientInterface module. Can we remove this and update corresponding lines of HttpClientInterface to httpClientInterface.
There was a problem hiding this comment.
Thanks, removed the duplicate entry as mentioned.
| @@ -37,7 +37,8 @@ const createHttpError = require('http-errors'); | |||
| const HttpServerInterface = require('onf-core-model-ap/applicationPattern/onfModel/models/layerProtocols/HttpServerInterface'); | |||
| const OperationClientInterface = require('onf-core-model-ap/applicationPattern/onfModel/models/layerProtocols/OperationClientInterface'); | |||
There was a problem hiding this comment.
We can see OperationClientInterface also has a duplicate import statement. Can we remove this and change corresponding lines of OperationClientInterface to operationClientInterface.
There was a problem hiding this comment.
Thanks, removed the duplicate entry.
2 participants
Fixes #968
Also some modification and refactoring done to the existing structure