Resolve To implement the PUT request to controller#46
Merged
PrathibaJee merged 2 commits intodevelopfrom Dec 5, 2023
Merged
Conversation
ManasaBM1
requested review from
IswaryaaS,
PrathibaJee and
sunil-kumar-meena
as code owners
Collaborator
Author
|
Reviewers is @PrathibaJee |
PrathibaJee
requested changes
Dec 5, 2023
Collaborator
PrathibaJee
left a comment
PrathibaJee
left a comment
There was a problem hiding this comment.
Overall its very nice. Kindly please incorporate the minor review comments. Thanks.
| * @param {object} eatlRequestHeaders httpRequestHeader to be sent to record the service information | ||
| * @returns {Integer} responseCode httpResponseCode received from the controller | ||
| */ | ||
| exports.postToLive = async function (requestBody, forwardingName, pathParams, stringProfileName, eatlRequestHeaders) { |
| * Perform ODL request and formulate final response | ||
| ****************************************************************************************/ | ||
|
|
||
| let responseCodeLiveResponse = await ODLOperations.postToLive(requestBody, forwardingName, pathParams, stringName, eatlRequestHeaders); |
Collaborator
There was a problem hiding this comment.
Attribute name shall be changed to "responseFromODL"
| let responseCode = responseCodeLiveResponse.responseCode | ||
| if (responseCode) { | ||
| response["response-code"] = responseCode; | ||
| let res = responseCodeLiveResponse.responseData; |
Collaborator
There was a problem hiding this comment.
Attribute shall be more specific like "responseDataFromODL"
| } | ||
| } | ||
|
|
||
| response["mac-fd-1-0:mac-table-entry-list"] = responseData |
Collaborator
There was a problem hiding this comment.
semi colon shall be included.
| var examples = {}; | ||
| examples['application/json'] = { | ||
| "response-code": 204 | ||
| exports.putLiveAirInterfacePerformanceMonitoringIsOn = async function (body, mountName, uuid, localId, user, originator, xCorrelator, traceIndicator, customerJourney) { |
Collaborator
There was a problem hiding this comment.
Please replicate the same comment provided for the previous function to all the below functionalities.
PrathibaJee
approved these changes
Dec 5, 2023
Collaborator
PrathibaJee
left a comment
PrathibaJee
left a comment
There was a problem hiding this comment.
Many thanks for resolving the review comments.
Good job !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24
Fixes #23