Skip to content

Resolved Support Version 2.0.0 changes for /v1/list-records , /v1/list-records-of-application#178

Merged
DanaSunal merged 1 commit intodevelopfrom
ManasaBM1/issue105
Feb 16, 2023
Merged

Resolved Support Version 2.0.0 changes for /v1/list-records , /v1/list-records-of-application#178
DanaSunal merged 1 commit intodevelopfrom
ManasaBM1/issue105

Conversation

@ManasaBM1
Copy link
Copy Markdown
Collaborator

Fixes #105
Fixes #108

@ManasaBM1
Copy link
Copy Markdown
Collaborator Author

Reviewer is @DanaSunal

body: {
query: {
term: {
"application-name": desiredApplicationName
Copy link
Copy Markdown
Collaborator

@DanaSunal DanaSunal Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not going to work. As the function comment in #177 states, the field is not searchable, if it's not of type 'keyword'. I missed this while reviewing #177 .

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working in my case even it is not of type keyword (it is type text )

@DanaSunal DanaSunal merged commit 3390e07 into develop Feb 16, 2023
@ManasaBM1 ManasaBM1 deleted the ManasaBM1/issue105 branch August 10, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Version 2.0.0 changes for V1/record-oam-request Support Version 2.0.0 changes for /v1/list-records , /v1/list-records-of-application

2 participants