Skip to content

Upgrade OL test-suite to support v2.0.0#206

Merged
IswaryaaS merged 3 commits intodevelopfrom
venkat-nallati/issue122
Apr 27, 2023
Merged

Upgrade OL test-suite to support v2.0.0#206
IswaryaaS merged 3 commits intodevelopfrom
venkat-nallati/issue122

Conversation

@venkat-nallati
Copy link
Copy Markdown
Collaborator

Fixes #122

Copy link
Copy Markdown
Collaborator

@IswaryaaS IswaryaaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/v1/bequeath-your-data-and-die:

  1. Forwardings triggered? :: reference OldRelease/core-model-1-4:control-construct :: Tests ::
  • recordOamRequestsOperationClientLtp support can be removed (it has been removed in v2)
  • line 72 : hope it is missed : the actual forwarding for /v1/regard-application of OL is NewApplicationCausesRequestForOamRequestInformation and the corresponding attribute name must be updated
  1. Similar to point 1, in Forwardings triggered? :: Expected ExecutionAndTraceLog/v1/list-records-of-flow for /v1/bequeath-your-data-and-die :: Tests :: the support for recordOamRequestsOperationClientLtp has to be removed.

/v1/regard-application:

  1. Forwardings triggered? :: reference /core-model-1-4:control-construct :: the attribute name for op-c should be redirectOamRequestInformationOperationClientLtp instead of inquireOamRequestApprovalsOperationClientLtp. kindly update for the attribute name in this request as well as in Expected ExecutionAndTraceLog/v1/list-records-of-flow :: Tests
  2. FC-port updated? :: the attribute redirectOamRequestInformationOperationClientLtp is retrived from a separate function, which is not necessary as it can be done in ltpInstance.operationClientLtp;
  3. FC port updated? :: Dummy /v1/regard-application :: pre-request script :: the attribute declaration must be updated.
    image
  4. FC port updated :: Dummy /v1/regard-application :: pre-request-script :: as used in other applications, dummyProtocol logic should be
    dummyProtocol = RandomProtocol().
  5. Update FC notified? :: reference /core-model-1-4:control-construct ::
    updateFcOperationClientLtp can be directly retrieved from "ServiceRequestCausesFcUpdateRequest". and ALT http-c can be obtained from updateFcOperationClientLtp. Kindly requesting you to update this logic.

(Also, i found the same logic in OKM and AA for both Update FC notified? and Delete LTP and dependents notified? (ServiceRequestCausesLtpDeletionRequest)). Could you please create a bug in those applications and fix this. Once fixed, raise a PR for the same)\

/v1/disregard-application:

  1. Attribute configured? :: client deleted? :: Dummy /v1/regard-application - application created? :: the attributes in below images are not necessary as we are not using anywhere in this testcase.
    image
  2. FC port deleted? :: reference /core-model-1-4:control-construct (both 1 and 3) :: Tests :: the attribute named linkUpdateNotificationOperationClientLtp must be updated as redirectOamRequestInformationOperationClientLtp.
  3. Delete LTP and dependents notified? :: reference /core-model-1-4:control-construct :: Tests :: the logic can be directly updated to get deleteLtpAndDependentsOperationClientLtp from ServiceRequestCausesLtpDeletionRequest and use deleteLtpAndDependentsOperationClientLtp to get ALT http-c.
    image

/v1/record-oam-request

  1. the attribute stringified-body is coming as [Object Object] as in below image.
    image
    In order to solve this, we can use the below solution in request body
    image

Copy link
Copy Markdown
Collaborator

@IswaryaaS IswaryaaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. i could see you have commented out few points which i asked you to remove... in future.. please make sure any unnecessary comment is not left behind.
  2. Few comments were left half addressed or improperly addressed. please find them below:
  • /v1/bequeath-your-data-and-die: 1.b ) i also requested to update attribute name , which was not addressed
  • /v1/bequeath-your-data-and-die: 2) support for recordOamRequestsOperationClientLtp has not completely removed in Expected EATL/list-records-of-flow:: Tests
  • /v1/regard-application : 5) only operarion name has been udpated and the forwarding was left as ServiceRequestCausesLtpUpdateRequest instead of ServiceRequestCausesFcUpdateRequest.

I have updated them myself and committed the changes to feature branch. Including the changes made for avoiding such mistakes in future.

@IswaryaaS IswaryaaS merged commit e89dec6 into develop Apr 27, 2023
@IswaryaaS IswaryaaS deleted the venkat-nallati/issue122 branch April 27, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade test-suite to support v2.0.0

2 participants