Upgrade OL test-suite to support v2.0.0#206
Merged
Conversation
IswaryaaS
requested changes
Apr 26, 2023
Collaborator
There was a problem hiding this comment.
/v1/bequeath-your-data-and-die:
- Forwardings triggered? :: reference OldRelease/core-model-1-4:control-construct :: Tests ::
- recordOamRequestsOperationClientLtp support can be removed (it has been removed in v2)
- line 72 : hope it is missed : the actual forwarding for /v1/regard-application of OL is NewApplicationCausesRequestForOamRequestInformation and the corresponding attribute name must be updated
- Similar to point 1, in Forwardings triggered? :: Expected ExecutionAndTraceLog/v1/list-records-of-flow for /v1/bequeath-your-data-and-die :: Tests :: the support for recordOamRequestsOperationClientLtp has to be removed.
/v1/regard-application:
- Forwardings triggered? :: reference /core-model-1-4:control-construct :: the attribute name for op-c should be redirectOamRequestInformationOperationClientLtp instead of inquireOamRequestApprovalsOperationClientLtp. kindly update for the attribute name in this request as well as in Expected ExecutionAndTraceLog/v1/list-records-of-flow :: Tests
- FC-port updated? :: the attribute redirectOamRequestInformationOperationClientLtp is retrived from a separate function, which is not necessary as it can be done in
ltpInstance.operationClientLtp; - FC port updated? :: Dummy /v1/regard-application :: pre-request script :: the attribute declaration must be updated.

- FC port updated :: Dummy /v1/regard-application :: pre-request-script :: as used in other applications, dummyProtocol logic should be
dummyProtocol = RandomProtocol(). - Update FC notified? :: reference /core-model-1-4:control-construct ::
updateFcOperationClientLtp can be directly retrieved from "ServiceRequestCausesFcUpdateRequest". and ALT http-c can be obtained from updateFcOperationClientLtp. Kindly requesting you to update this logic.
(Also, i found the same logic in OKM and AA for both Update FC notified? and Delete LTP and dependents notified? (ServiceRequestCausesLtpDeletionRequest)). Could you please create a bug in those applications and fix this. Once fixed, raise a PR for the same)\
/v1/disregard-application:
- Attribute configured? :: client deleted? :: Dummy /v1/regard-application - application created? :: the attributes in below images are not necessary as we are not using anywhere in this testcase.

- FC port deleted? :: reference /core-model-1-4:control-construct (both 1 and 3) :: Tests :: the attribute named linkUpdateNotificationOperationClientLtp must be updated as redirectOamRequestInformationOperationClientLtp.
- Delete LTP and dependents notified? :: reference /core-model-1-4:control-construct :: Tests :: the logic can be directly updated to get deleteLtpAndDependentsOperationClientLtp from ServiceRequestCausesLtpDeletionRequest and use deleteLtpAndDependentsOperationClientLtp to get ALT http-c.

/v1/record-oam-request
IswaryaaS
reviewed
Apr 27, 2023
Collaborator
IswaryaaS
left a comment
There was a problem hiding this comment.
- i could see you have commented out few points which i asked you to remove... in future.. please make sure any unnecessary comment is not left behind.
- Few comments were left half addressed or improperly addressed. please find them below:
- /v1/bequeath-your-data-and-die: 1.b ) i also requested to update attribute name , which was not addressed
- /v1/bequeath-your-data-and-die: 2) support for recordOamRequestsOperationClientLtp has not completely removed in Expected EATL/list-records-of-flow:: Tests
- /v1/regard-application : 5) only operarion name has been udpated and the forwarding was left as ServiceRequestCausesLtpUpdateRequest instead of ServiceRequestCausesFcUpdateRequest.
I have updated them myself and committed the changes to feature branch. Including the changes made for avoiding such mistakes in future.
IswaryaaS
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #122