Skip to content

New approach for MQTT module#3

Merged
viacheslauK merged 57 commits intomainfrom
newApproach
Nov 13, 2025
Merged

New approach for MQTT module#3
viacheslauK merged 57 commits intomainfrom
newApproach

Conversation

@viacheslauK
Copy link
Copy Markdown
Collaborator

@viacheslauK viacheslauK commented Oct 21, 2025 •
edited
Loading

Brief

  • New MQTT functional block - @rawMqttFb;
  • New MQTT functional block - @jsonMqttFb;
  • New "SignalList" property approach;
  • New "signals" topic approach;
  • New example applications: custom-mqtt-sub, ref-dev-mqtt-raw-sub;
  • New device property - DiscoveryTimeout;
  • Using of MQTT brocker port;
  • Unsubscribing when a FB is removed or deleted;
  • Supporting for different value types: int64_t, double, string;
  • New logs;
  • Improved stability;
  • Tests;

viacheslauK and others added 13 commits October 14, 2025 16:14
@viacheslauK viacheslauK self-assigned this Oct 21, 2025
@viacheslauK
mqtt: bugfix - moving creating of available FB types to device constr…
67e490b 
…uctor;

Couldn't create device if getAvailableFunctionBlockTypes() has not been called;
Now getAvailableFunctionBlockTypes() only returns Dict;
@viacheslauK
mqtt: exeption if user tries to add more then one MQTT device
93328b2
@viacheslauK
mqtt: correct name for MQTT device type
a563bf3
@viacheslauK
mqtt: topic validation for raw MQTT FB
9097ab7
@viacheslauK
mqtt: renaming and logs
eaa8258
@viacheslauK
mqtt: tests for Raw MQTT FB
004d6ee
@viacheslauK
mqtt: unnecessary include removing
af65ba3
@viacheslauK
mqtt: new device property - DiscoveryTimeout; renaming InitDelay -> C…
1df968e 
…onnectTimeout;
@viacheslauK
mqtt: topic validation for JSON config
5511ad5
@viacheslauK
mqtt: if JSON config for JSON FB contains a extraction field that fie…
2ea3f11 
…ld is required in a data msg
@viacheslauK
mqtt: check if a topic descriptor is present
c2b20a6
@viacheslauK
mqtt: static methods for MQTT FBs for building signal names
87bb56e
@viacheslauK
mqtt: const for method arguments
9c29ae6
@viacheslauK
mqtt: JSON FB - check if subscriber is set, otherwise set a component…
b046f7c 
… status error
@viacheslauK
mqtt: tests for the MQTT module
1fd6587
@viacheslauK
mqtt: tests for timestamp parsing
6e144e5
@viacheslauK viacheslauK marked this pull request as ready for review November 5, 2025 15:53
NikolaiShipilov
NikolaiShipilov requested changes Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown

@NikolaiShipilov NikolaiShipilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added several comments - some to be addressed in this PR, others as ideas for future refactoring

Comment thread mqtt_streaming_server_module/src/mqtt_streaming_server_impl.cpp
Comment thread external/opendaq/CMakeLists.txt Outdated
Comment thread examples/custom-mqtt-sub/src/CMakeLists.txt Outdated
Comment thread mqtt_streaming_protocol/include/MqttAsyncClient.h
Comment thread mqtt_streaming_protocol/include/MqttDataWrapper.h
Comment thread mqtt_streaming_client_module/src/mqtt_base_fb.cpp
Comment thread mqtt_streaming_client_module/src/mqtt_streaming_device_impl.cpp
Comment thread mqtt_streaming_client_module/src/mqtt_streaming_device_impl.cpp
Comment thread mqtt_streaming_client_module/src/mqtt_json_receiver_fb_impl.cpp Outdated
Comment thread mqtt_streaming_client_module/src/mqtt_json_receiver_fb_impl.cpp
@NikolaiShipilov NikolaiShipilov self-requested a review November 13, 2025 17:10
@viacheslauK viacheslauK merged commit 249eb50 into main Nov 13, 2025
@viacheslauK viacheslauK deleted the newApproach branch December 8, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikolaiShipilov NikolaiShipilov NikolaiShipilov approved these changes

Assignees

@viacheslauK viacheslauK

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@viacheslauK @NikolaiShipilov