Merged
Conversation
viacheslauK
force-pushed
the
publisher-improving
branch
from
6452e22 to
d5fa5d9
Compare
viacheslauK
changed the title
NikolaiShipilov
approved these changes
Dec 24, 2025
NikolaiShipilov
left a comment
NikolaiShipilov
left a comment
There was a problem hiding this comment.
lgtm 👍 .
Added comments, as usual, could be fixed (if applicable) in the following PRs.
Also, I would suggest renaming of mqtt_base_fb.h/cpp and containing class by adding word "receiver" there to distinct it from publisherFb and rootFb.
|
|
||
| void restart() | ||
| { | ||
| firstStart = false; |
There was a problem hiding this comment.
Seems like that assignment should go last in this method - after start value is initialized
Comment on lines
+93
to
+96
| const std::string msg = "MQTT subscriber client is not set!"; | ||
| setComponentStatusWithMessage(ComponentStatus::Error, msg); | ||
| setSubscriptionStatus(SubscriptionStatus::SubscribingError, msg); | ||
| result = {false, msg}; |
There was a problem hiding this comment.
"MQTT subscriber client is not set!" message is a bit confusing for end-user as it refers to internal implementation details.
Anyway, here and in unsubscribeFromTopic the case when MqttAsyncClient class-member pointer is not assigned seems not reachable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief: