Skip to content

Migrate mailers to use parametrized attributes#2061

Merged
MrSerth merged 1 commit intomainfrom
ss/parameterized_mailers
Jul 4, 2025
Merged

Migrate mailers to use parametrized attributes#2061
MrSerth merged 1 commit intomainfrom
ss/parameterized_mailers

Conversation

@MrSerth
Copy link
Member

@MrSerth MrSerth commented Jul 2, 2025

Related to CodeOcean #2959, we migrate all mailers to use parameterized attributes, since this should work better with testing.

@MrSerth MrSerth self-assigned this Jul 2, 2025
@MrSerth MrSerth added enhancement ruby Pull requests that update Ruby code labels Jul 2, 2025
@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.85%. Comparing base (5dc4094) to head (694af10).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2061   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         133      133           
  Lines        3385     3385           
=======================================
  Hits         3211     3211           
  Misses        174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MrSerth MrSerth merged commit 03a1cef into main Jul 4, 2025
10 checks passed
@MrSerth MrSerth deleted the ss/parameterized_mailers branch July 4, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ruby Pull requests that update Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments