Startup time improvement and Dynamic Shortcuts#1371
Conversation
Addded Dynamic Shortcuts, which provide easy access to Center, Group, Settings and Clients Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
Gelassen
left a comment
There was a problem hiding this comment.
Don't you want to do this logic in cycle? Code is repeat five times, instead you could move this strings and drawable consts into two arrays and iterate over it by creating shortcut and adding it into the final collection.
|
Are all the shortcuts working? |
@robustTechie Yes, they are. |
|
Also, add screen recoding for that, so it would be better for the reviewer to see the changes. :) |
|
@nirmalhk7 Please squash your commits into one. |
…plashscreenActivity Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
I have a merge commit between two of my other commits, and Im not quite sure how to rebase them now because I really dont want to mess Git's history. Do you have any suggestions on what to do? |
|
@nirmalhk7 Why are other contributors commits are showing in your commit? |
@RajaVamsi11 I'm not quite sure, and that is why I dont want to mess around. I dont mind redoing my work again, but I would mind if someone else had to redo their work because I wasn't careful. |
|
The commits that are showing up in your commit list are already merged in the master branch. You do not worry about their commits as they are already merged. |
Okay, so how do I squash then? |
|
You can follow this one https://www.internalpointers.com/post/squash-commits-into-one-git |
|
Hello @nirmalhk7, Can you please squash your commits? I'm closing your pull request for now. Please re-open this pull request when you have made the suggested changes. Thank you for your contribution. |
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.