Skip to content

Startup time improvement and Dynamic Shortcuts#1371

Closed
nirmalhk7 wants to merge 5 commits into
openMF:masterfrom
nirmalhk7:master
Closed

Startup time improvement and Dynamic Shortcuts#1371
nirmalhk7 wants to merge 5 commits into
openMF:masterfrom
nirmalhk7:master

Conversation

@nirmalhk7
Copy link
Copy Markdown

@nirmalhk7 nirmalhk7 commented Mar 2, 2020

  • Fixes Adding shortcuts to Android #1314
  • I've also removed the SetContentView() in SplashScreen, which is unnecessary as the SplashScreen already loads the logo from the style.xml, thus improving startup time.

Please Add Screenshots If there are any UI changes.

untitled

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Addded Dynamic Shortcuts, which provide easy access to Center, Group, Settings and Clients

Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
Copy link
Copy Markdown

@Gelassen Gelassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want to do this logic in cycle? Code is repeat five times, instead you could move this strings and drawable consts into two arrays and iterate over it by creating shortcut and adding it into the final collection.

@nirmalhk7 nirmalhk7 marked this pull request as ready for review March 6, 2020 06:08
@nirmalhk7 nirmalhk7 changed the title Added Dynamic Shortcuts Startup time improvement and Dynamic Shortcuts Mar 6, 2020
@iamsh4shank
Copy link
Copy Markdown
Member

Are all the shortcuts working?

@nirmalhk7
Copy link
Copy Markdown
Author

Are all the shortcuts working?

@robustTechie Yes, they are.

@iamsh4shank
Copy link
Copy Markdown
Member

Also, add screen recoding for that, so it would be better for the reviewer to see the changes. :)

@RajaVamsi11
Copy link
Copy Markdown
Contributor

@nirmalhk7 Please squash your commits into one.

…plashscreenActivity

Signed-off-by: Nirmal Khedkar <nirmalhk7@gmail.com>
@nirmalhk7
Copy link
Copy Markdown
Author

@nirmalhk7 Please squash your commits into one.

I have a merge commit between two of my other commits, and Im not quite sure how to rebase them now because I really dont want to mess Git's history. Do you have any suggestions on what to do?

@RajaVamsi11
Copy link
Copy Markdown
Contributor

@nirmalhk7 Why are other contributors commits are showing in your commit?

@nirmalhk7
Copy link
Copy Markdown
Author

@nirmalhk7 Why are other contributors commits are showing in your commit?

@RajaVamsi11 I'm not quite sure, and that is why I dont want to mess around. I dont mind redoing my work again, but I would mind if someone else had to redo their work because I wasn't careful.

@RajaVamsi11
Copy link
Copy Markdown
Contributor

The commits that are showing up in your commit list are already merged in the master branch. You do not worry about their commits as they are already merged.

@nirmalhk7
Copy link
Copy Markdown
Author

The commits that are showing up in your commit list are already merged in the master branch. You do not worry about their commits as they are already merged.

Okay, so how do I squash then?

@RajaVamsi11
Copy link
Copy Markdown
Contributor

@AbhilashG001
Copy link
Copy Markdown
Member

Hello @nirmalhk7,

Can you please squash your commits?

I'm closing your pull request for now. Please re-open this pull request when you have made the suggested changes.

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding shortcuts to Android

7 participants