Skip to content

Conversation

@danishjamal104
Copy link
Collaborator

@danishjamal104 danishjamal104 commented Nov 29, 2020

Fixes #1580

Screenshot

Screenshot 2020-11-15 at 10 44 03 PM

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@danishjamal104 danishjamal104 changed the title Fixes 1580 network check added before initiating search api call Fixes #1580 network check added before initiating search api call Nov 29, 2020
@danishjamal104
Copy link
Collaborator Author

@robustTechie please review the changes.
Thanks:)

Copy link
Member

@iamsh4shank iamsh4shank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the screenshot :)

@danishjamal104
Copy link
Collaborator Author

Can you update the screenshot :)

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard doesn't show proper toast when the user is not connected to the network.

3 participants