datatables and savingsAccounts data managers migrated to sdk

.github/workflows/android.yml

@@ -1,26 +1,126 @@
-name: Android Build 
-on: [push, pull_request]
+name: Android Client CI
+on:
+  push:
+  pull_request:
+    branches:
+      - master
+
 jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-
-      # Set up JDK 1.8
-    - name: set up JDK 1.8
-      uses: actions/setup-java@v1
-      with:
-        java-version: 1.8
-
-      # Build with Gradle
-    - name: Build with Gradle
-      run: chmod +x gradlew && ./gradlew build check
-
-      # Upload Build Artifact
-    - name: Upload Build Artifacts
-      uses: actions/upload-artifact@v2.2.0
-      with:
-        # Artifact name
-        name: apk-debug
-        # File path describing what artifact to upload
-        path: app/build/outputs/apk/debug/app-debug.apk
+      - uses: actions/checkout@v2
+
+        # Set up JDK 1.8
+      - name: Set up JDK 1.8
+        uses: actions/setup-java@v1
+        with:
+          java-version: 1.8
+
+        # Build with Gradle
+      - name: Build with Gradle
+        run: chmod +x gradlew && ./gradlew assembleDebug
+
+        # Upload APK
+      - name: Upload APK
+        uses: actions/upload-artifact@v2.2.0
+        with:
+          # Artifact name
+          name: android-client-app
+          # File path describing what artifact to upload
+          path: mifosng-android/build/outputs/apk/debug/mifosng-android-debug.apk
+
+  test:
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+        # Test with Gradle
+      - name: Test App
+        run: ./gradlew test
+
+        # Upload test reports
+      - name: Upload Test Reports
+        uses: actions/upload-artifact@v2.2.0
+        with:
+          # Artifact name
+          name: test-reports
+          # File path describing what artifact to upload
+          path: mifosng-android/build/reports/tests/**
+
+  lintCheck:
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+        # Perform Lint Check
+      - name: Lint Check
+        run: ./gradlew lint
+
+        # Upload reports
+      - name: Upload Lint Reports
+        uses: actions/upload-artifact@v2.2.0
+        with:
+          # Artifact name
+          name: lint-reports
+          # File path describing what artifact to upload
+          path: mifosng-android/build/reports/lint-results**
+
+  pmd:
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+        # Perform PMD Check
+      - name: PMD Check
+        run: ./gradlew pmd
+
+        # Upload reports
+      - name: Upload PMD Reports
+        uses: actions/upload-artifact@v2.2.0
+        with:
+          # Artifact name
+          name: pmd-reports
+          # File path describing what artifact to upload
+          path: mifosng-android/build/reports/pmd/**
+
+  checkstyle:
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+        # Perform Checkstyle Check
+      - name: Checkstyle
+        run: ./gradlew checkstyle
+
+        # Upload reports
+      - name: Upload Checkstyle Reports
+        uses: actions/upload-artifact@v2.2.0
+        with:
+          # Artifact name
+          name: checkstyle-reports
+          # File path describing what artifact to upload
+          path: mifosng-android/build/reports/checkstyle/**
+
+  findbugs:
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+        # Find bugs Check
+      - name: Findbugs
+        run: ./gradlew findbugs
+
+        # Upload reports
+      - name: Upload Checkstyle Reports
+        uses: actions/upload-artifact@v2.2.0
+        with:
+          # Artifact name
+          name: findbugs-reports
+          # File path describing what artifact to upload
+          path: mifosng-android/build/reports/findbugs/**

mifosng-android/build.gradle

@@ -9,6 +9,7 @@ buildscript {
         google()
         mavenCentral()
         maven { url 'https://maven.fabric.io/public' }
+        maven { url "https://jitpack.io" }
         jcenter()
     }
     dependencies {
@@ -105,7 +106,6 @@ android {
             proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
             testProguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguardTest-rules.pro'
         }
-
     }
     lintOptions {
         abortOnError false
@@ -114,7 +114,6 @@ android {
         disable 'OutdatedLibrary'
     }
 
-
     // Exclude duplicated Hamcrest LICENSE.txt from being packaged into the apk.
     // This is a workaround for https://code.google.com/p/android/issues/detail?id=65445.
     // The Hamcrest is used in tests.
@@ -135,7 +134,6 @@ android {
 
 task buildAndEMailAPK(type: Exec, description: 'Builds and Generates a Signed APK and emails it') {
 
-
 }
 
 tasks.withType(JavaCompile) {
@@ -179,6 +177,11 @@ dependencies {
     implementation "com.google.maps.android:android-maps-utils:$rootProject.mapUtilsServices"
     implementation 'androidx.test.espresso:espresso-idling-resource:3.1.0'
 
+    //Bottom navigation
+    implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
+    implementation 'androidx.navigation:navigation-fragment:2.2.2'
+    implementation 'androidx.navigation:navigation-ui:2.2.2'
+
     //Dagger dependencies
     annotationProcessor "com.google.dagger:dagger-compiler:$rootProject.daggerVersion"
     implementation "com.google.dagger:dagger:$rootProject.daggerVersion"
@@ -217,6 +220,8 @@ dependencies {
     implementation 'com.facebook.stetho:stetho:1.3.1'
     implementation 'com.facebook.stetho:stetho-okhttp3:1.3.1'
 
+    implementation 'com.github.deano2390:MaterialShowcaseView:1.3.4'
+
 
     implementation "com.joanzapata.iconify:android-iconify-material:2.1.1" // (v2.0.0)
     implementation('com.crashlytics.sdk.android:crashlytics:2.6.6@aar') {
@@ -225,7 +230,6 @@ dependencies {
     implementation 'com.amulyakhare:com.amulyakhare.textdrawable:1.0.1'
     implementation 'com.github.bumptech.glide:glide:3.7.0'
 
-
     //mifos passcode
     implementation "com.mifos.mobile:mifos-passcode:$mifosPasscodeVersion"
 
@@ -257,7 +261,6 @@ dependencies {
     //preferences
     implementation "androidx.preference:preference:$preference"
 }
-
 /*
 All direct/transitive dependencies shared between your test and production APKs need to be
 excluded from the test APK! This is necessary because both APKs will contain the same classes. Not

mifosng-android/src/instrumentTest/java/com/mifos/mifosxdroid/tests/SavingsAccountSummaryFragmentTest.java

@@ -16,7 +16,6 @@
 
 import com.mifos.mifosxdroid.R;
 import com.mifos.mifosxdroid.online.ClientActivity;
-import com.mifos.mifosxdroid.online.savingaccountsummary.SavingsAccountSummaryFragment;
 import com.mifos.mifosxdroid.online.documentlist.DocumentListFragment;
 import com.mifos.objects.accounts.savings.DepositType;
 import com.mifos.utils.Constants;

mifosng-android/src/instrumentTest/java/com/mifos/mifosxdroid/tests/SurveyQuestionViewPagerActivityTest.java

@@ -10,7 +10,6 @@
 import android.test.suitebuilder.annotation.MediumTest;
 
 import com.mifos.mifosxdroid.R;
-import com.mifos.mifosxdroid.online.SurveyQuestionActivity;
 
 import static androidx.test.espresso.Espresso.onView;
 import static androidx.test.espresso.action.ViewActions.click;

mifosng-android/src/main/AndroidManifest.xml

@@ -46,14 +46,26 @@
             android:name=".login.LoginActivity"
             android:label="@string/mifos_account"
             android:screenOrientation="portrait" />
+        <activity
+            android:name=".HomeActivity"
+            android:label="home_activity"
+            android:windowSoftInputMode="adjustPan"
+            android:screenOrientation="portrait" />
         <activity
             android:name=".online.DashboardActivity"
             android:label="@string/dashboard"
             android:screenOrientation="portrait" />
+
         <activity
             android:name=".online.SurveyQuestionActivity"
             android:label="Survey"
-            android:screenOrientation="portrait" />
+            android:parentActivityName="com.mifos.mifosxdroid.online.ClientActivity"
+            android:screenOrientation="portrait">
+            <meta-data
+                android:name="android.support.PARENT_ACTIVITY"
+                android:value="com.mifos.mifosxdroid.online.ClientActivity"/>
+        </activity>
+
         <activity
             android:name=".online.GroupsActivity"
             android:configChanges="orientation|screenSize"
@@ -66,27 +78,27 @@
             android:name=".online.CentersActivity"
             android:label="@string/title_activity_centers"
             android:screenOrientation="portrait"
-            android:parentActivityName=".online.DashboardActivity">
+            android:parentActivityName=".HomeActivity">
             <meta-data
                 android:name="android.support.PARENT_ACTIVITY"
-                android:value=".online.DashboardActivity" />
+                android:value=".HomeActivity" />
         </activity>
         <activity
             android:name=".online.GenerateCollectionSheetActivity"
             android:configChanges="orientation|screenSize"
             android:label="@string/title_activity_generate_collection_sheet"
-            android:parentActivityName=".online.DashboardActivity">
+            android:parentActivityName=".HomeActivity">
             <meta-data
                 android:name="android.support.PARENT_ACTIVITY"
-                android:value=".online.DashboardActivity" />
+                android:value=".HomeActivity" />
         </activity>
         <activity
             android:name=".online.RunReportsActivity"
             android:label="@string/run_report"
-            android:parentActivityName=".online.DashboardActivity">
+            android:parentActivityName=".HomeActivity">
             <meta-data
                 android:name="android.support.PARENT_ACTIVITY"
-                android:value=".online.DashboardActivity" />
+                android:value=".HomeActivity" />
         </activity>
         <activity
             android:name=".ClientListActivity"
@@ -129,7 +141,12 @@
         <activity
             android:name=".SettingsActivity"
             android:label="@string/settings"
-            android:screenOrientation="portrait" />
+            android:screenOrientation="portrait"
+            android:parentActivityName=".HomeActivity">
+            <meta-data
+                android:name="android.support.PARENT_ACTIVITY"
+                android:value=".HomeActivity" />
+        </activity>
         <activity
             android:name=".offline.syncsavingsaccounttransaction.SyncSavingsAccountTransactionActivity"
             android:label="@string/sync_savingsaccounttransactions"