New Feature: Allow user to update server configuration #2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[x] Created UpdateServerConfigScreen.kt [x] Created Validation Use Cases Saved Config in Preference Manager [x] Applied in :app, :auth module [] Applied in Network Module
|
@therajanmaurya kindly review this PR, I haven't applied in :network module yet, this is the main internal part like the heart of our app, so I would like to discuss it with you before using it in the module, it will be better if we could join a meeting with @Aditya-gupta99 to share my thoughts properly. |
|
This does not need to interact with network module. It will interact with data - datastore module |
|
yes sir but i think we have to configure BaseApiManager as well because in their we are using prefManager |
|
@therajanmaurya sir applied config in network module, kindly take a look |
…g-on-login-screen
niyajali
deleted the
MIFOSAC-167-allow-user-to-set-server-config-on-login-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MIFOSAC-167
Please Add Screenshots If there are any UI changes.
Screen_recording_20240601_091831.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.