refactor: refactor About activity to compose #2115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratyushSingh07
suggested changes
Jun 25, 2024
feature/about/src/main/java/com/mifos/feature/about/AboutScreen.kt
Outdated
Show resolved
Hide resolved
feature/about/src/main/java/com/mifos/feature/about/AboutScreen.kt
Outdated
Show resolved
Hide resolved
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Jul 2, 2024
* refactor: refactor About activity to compose * fix : added text style
therajanmaurya
pushed a commit
that referenced
this pull request
Jul 7, 2024
* MIFOSAC-184 Migrate loan account summary to compose backUp backup backup backup * fix: build fail (#2118) * refactor: refactor About activity to compose (#2115) * refactor: refactor About activity to compose * fix : added text style * refactor: refactor Create new center fragment to compose (#2116) * refactor: refactor Create new center fragment to compose * fix: fix build fail * refactor: refactor client charge fragment to compose (#2120) * Migrate Data Table Fragment to compose (#2119) migrate dataTable to compose topbar fix removed extra file fix topbar made required changes * add scrollState * removed unused function remove extra icon added horizontal padding 24.dp fix scale Fix scale --------- Co-authored-by: Aditya Gupta <94394661+Aditya-gupta99@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JiraMIFOSAC-176
XML Screen
Record_2024-06-23-23-44-10.mp4
Jetpack Compose
Record_2024-06-24-01-02-05.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.