498. Remove the visible DialogBox after Identifier creation submission#2445
Closed
Shreyash16b wants to merge 1 commit intoopenMF:developmentfrom
Closed
498. Remove the visible DialogBox after Identifier creation submission#2445Shreyash16b wants to merge 1 commit intoopenMF:developmentfrom
Shreyash16b wants to merge 1 commit intoopenMF:developmentfrom
Conversation
itsPronay
suggested changes
Aug 4, 2025
Comment on lines
+96
to
+103
| if (state is ClientIdentifierDialogUiState.IdentifierCreatedSuccessfully) { | ||
| Toast.makeText( | ||
| LocalContext.current, | ||
| stringResource(id = R.string.feature_client_identifier_created_successfully), | ||
| Toast.LENGTH_SHORT, | ||
| ).show() | ||
| onIdentifierCreated() | ||
| } |
Contributor
There was a problem hiding this comment.
why you adding it here! We exactly have the same code inside the when block
Contributor
Author
There was a problem hiding this comment.
The issue to be solved has the dialog box showing the Create Identifier text and close icon even after submission and Loading Dialog Box. I have updated the Before video to show it on my device. Using the development branch for this.
- Look at 8 second mark you see the screenshot in this PR after clicking submit (just for one frame) before the success toast. So, I added a success check before the dialog box.
- At around 11 second mark I click on the add identifier icon again, but it shows the success toast again instead of dialog box.
Member
|
Closing in response of #2450 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - MIFSOAC-498
Before :
MIFOSAC-498_Before.mp4
There exists this dialog box (at 8 seconds in above video) even after successful creation of the identifier
After :
MIFOSAC-498_After.mp4
Changes:
ClientIdentifierDialogUiState.IdentifierCreatedSuccessfullyand not display the dialog if successful.Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.