Client Add/Edit Note #2480
Client Add/Edit Note #2480
Conversation
| ) | ||
|
|
||
| OutlinedTextField( | ||
| value = state.textFieldNotesPayload.note ?: "", |
There was a problem hiding this comment.
we have MifosOutLined TextField can't we use it here?
There was a problem hiding this comment.
Yeah we can use but make some changes like shape, textstyle and color use. one MifosOutLined TextField composable have these all but it have trailing space which is the text is not start from starting.
There was a problem hiding this comment.
i think some one edited it it is taking leading icon space eventhough it was not there
see once
| } | ||
| }.onFailure { | ||
| mutableStateFlow.update { | ||
| it.copy( |
There was a problem hiding this comment.
can't we use
DataState.Loading
DataState.Success
DataState.Failure
that approach because it was the one following in mifos repos
| composable<NoteRoute> { updateNoteList -> | ||
| NoteScreenScaffold( | ||
| onNavigateBack = onNavigateBack, | ||
| onNavigateAddEditNote = onNavigateAddEditNote, |
There was a problem hiding this comment.
instead fetch this in viewmodel from savedStateHandle
There was a problem hiding this comment.
when I go back from edit screen then the previous screen not automatically update and when I use savedStateHandle in viewModel then it not call loadnote function again to refresh data.
There was a problem hiding this comment.
I means viemModel not fetch savedStateHandle data when I navigateBack from editnoteScreen to noteListScreen
Arinyadav1
force-pushed
the
addEditNotes
branch
from
d27c8fc to
06958a3
Compare
3 participants
Fixes - Jira-#582