Skip to content

Fix:Empty Signature Uploads #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Fix:Empty Signature Uploads #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mifosng-android/src/main/java/com/mifos/mifosxdroid/online/sign/SignatureFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,10 @@ public void showProgressbar(boolean b) {

@Override
public void saveAndUploadSignature() {
signView.saveSignature(mClientId);
if (signView.getXCoordinateSize() > 0 && signView.getYCoordinateSize() > 0) {
signView.saveSignature(mClientId);
} else {
Toaster.show(rootView, R.string.empty_signature);
}
}
}
8 changes: 8 additions & 0 deletions mifosng-android/src/main/java/com/mifos/mifosxdroid/views/SignatureView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,4 +141,12 @@ public void clear() {
destroyDrawingCache();
invalidate();
}

public int getXCoordinateSize() {
return mXCoordinateList.size();
}

public int getYCoordinateSize() {
return mYCoordinateList.size();
}
}
1 change: 1 addition & 0 deletions mifosng-android/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@
<string name="sign_dir_not_created_msg">Something went wrong. Couldn\'t create directory.</string>
<string name="sign_saved_success_msg">File saved successfully in </string>
<string name="uploading_sign_msg">Uploading signature %#8230</string>
<string name="empty_signature">No Signature Recorded</string>
<!-- Signature Related Strings Ends -->


Expand Down