Bump neuroimaging commit for v5.0 to include device fix#100
Merged
Conversation
The v5.0 pin was at fe3b615 (2026-03-11), which predates the commit that added the 'device' property to MRIScannerUsage.schema.tpl.json. Updated to 3f2838a (current v1 HEAD), which includes bec65af 'Add device field for MRI Scanner in schema'.
Raphael-Gazzotti
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99
Updates the
neuroimagingpin for v5.0 inversions.jsonfromfe3b615b718065860c342cb2490f1ec5203791c7to3f2838a857b0d8832fe2d4617847d92dbf7360bb(current v1 HEAD).The old pin predated openMetadataInitiative/openMINDS_neuroimaging#60, which
added
devicetoMRIScannerUsage.schema.tpl.json. As a result, the compiledMRIScannerUsage.schema.omi.jsonfor v5.0 was missingdevicefrom itspropertiesblock even though it appeared inrequired.Commits between old and new pin
Four commits are brought in by this bump:
bec65afMRIScannerUsage.schema.tpl.json— addsdeviceproperty (the fix, openMetadataInitiative/openMINDS_neuroimaging#60)96605656ac841a.github/workflows/openMINDS_upstream.yml— one line added to a CI workflow trigger, no schema impact3f2838aNo schema files are touched other than the
devicefix itself, so there is no risk of unintended schema changes.