Skip to content

Conversation

@ehennestad
Copy link
Collaborator

Rename folder containing generated MATLAB classes from "schemas" to "types".

The folder really contains classes for metadata types, not schemas, so "types" appears to be a more precise name for the folder.

Also some smaller changes to docstrings/disp statements using the updated terminology guidelines here:
openMetadataInitiative/openMINDS_documentation#35

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Test Results

466 tests  ±0   466 ✅ ±0   58s ⏱️ +2s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 5339d8c. ± Comparison against base commit d77854f.

@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 28.35%. Comparing base (d13ea5a) to head (5339d8c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../+internal/+vocab/getFullClassNameFromSchemaName.m 0.00% 5 Missing ⚠️
code/+openminds/getModelVersion.m 75.00% 1 Missing ⚠️
code/internal/+openminds/+internal/update.m 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   36.04%   28.35%   -7.70%     
==========================================
  Files         327      108     -219     
  Lines        3204     2814     -390     
==========================================
- Hits         1155      798     -357     
+ Misses       2049     2016      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehennestad ehennestad merged commit 3cef164 into main Apr 3, 2025
5 checks passed
@ehennestad ehennestad deleted the rename-schema-to-type branch April 3, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants