Fix tests and tutorials for openMINDS v5#90
Merged
ehennestad merged 9 commits intomainfrom Apr 28, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "contactInformation", contacts(person.email) }; | ||
|
|
||
| if ommtest.oneoffs.currentSchemaMajorVersion() >= 5 | ||
| personArguments = [personArguments, { ... |
Contributor
Test Results (R2021b)568 tests 566 ✅ 1m 34s ⏱️ For more details on these errors, see this check. Results for commit 6e2156c. ♻️ This comment has been updated with latest results. |
Contributor
Test Results (R2024b)568 tests 566 ✅ 1m 25s ⏱️ For more details on these errors, see this check. Results for commit 6e2156c. ♻️ This comment has been updated with latest results. |
Simplify function, using existing function for schema version introspection
Revert latest change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note: this PR is the base for the controlled-term follow-up branch.