test_attr: user-friendly type list#51
Merged
ax3l merged 1 commit intoopenPMD:1.1.Xfrom Nov 6, 2019
Merged
Conversation
Checking the allowed types for attributes such as `timeOffset` gave a suboptimal user-hint of the form: ``` Error: Attribute timeOffset in /data/0/particles/electron/positionOffset` is not of type '<map object at 0x11aa73050>' (is 'float32')!` ``` Let's concat the types properly to ``` Error: Attribute timeOffset in /data/0/particles/electron/positionOffset` is not of type 'float32' or 'float64' (is 'str')! ``` Thanks for the report, @rfbird! ✨
RemiLehe
approved these changes
Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking the allowed types for attributes such as
timeOffsetgave a sub-optimal user-hint of the form:Let's concat the types properly to
Thanks for the report, @rfbird! ✨