Bug in Variations you did not enter

[duartemolha]

Hi
when in the section "Variations you did not enter", when you initially click on one (in thie case Astigmatism) I am greeted with a popup where you can either write a text to describe your variation or choose from the list below.

I initially clicked one of the options and the free text option on top disappeared. However, after reading the options I decided none of them really described my phenotype correctly so because I wanted to use the free text option I closed the popup without clicking OK

When I clicked on Astigmatism option again the free-text option would not show up again and one the multiple choice options was selected.

I believe if the user does not click ok and navigates out of the popup, the multiple choice he innitialy clicked should not be accepted as valid and thus when navigating back to the variation, the free-text option should be visible.

[tsujigiri]

Thank you very much for reporting this! You earned +1 bug reporting karma. :) One of us will look into it as soon as he finds the time.

[duartemolha]

you're welcome.

[gedankenstuecke]

This bug even goes a bit further, because it removes all free-text input fields as I've just found out. This is due to the fact that we do a blanket $('input[type=radio]').click(function() in the view, without specifying to what the button should belonging to.

So fixing that might be a bit more complicated?

[7yl4r]

I think this code snippet is all that is needed, but I'm not sure what file it should go in (I'm unfamiliar with ruby project layout).

$('.close').click(function(){
    $('input[type=text]').show();
})

[gedankenstuecke]

I guess that could go into app/views/user_phenotypes/_form.html.erb? But I assume that @tsujigiri has a better idea of how to correctly do it 😉

[tsujigiri]

JavaScript should go into app/assets/javascripts. Since we don't have much JavaScript, application.js should be fine. I know we have a lot of inline JS aready, I think we should clean that up as well.

[gedankenstuecke]

Ah, thanks. Do we already have a Issue open for that?

[tsujigiri]

None that I know of.

[7yl4r]

@gedankenstuecke : can you tell me how to reproduce this bug "remove[ing] all free-text input fields"? Looking this line I wouldn't expect that behavior, and if it is true there may be more to this bug than I originally thought. @tsujigiri rightly suggested I be more specific with my jquery selector, but then that won't address the other affected text fields.

[gedankenstuecke]

@7yl4r: Yes, I think the issue reported here is another one: After logging in there will be a list of phenotypes you've not entered yet. If you click on the button to add new ones the modal will open giving you the different options.

Once you click on one of the radio buttons the free-text input field in the modal will disappear.

Now, if you close that modal and open it again the free text field will stay hidden and there's no way to get it back. Does that help? 😄