fix #109: Rename models/config_model to models/config#116
Merged
tomschr merged 2 commits intoopenSUSE:mainfrom Dec 10, 2025
Merged
fix #109: Rename models/config_model to models/config#116tomschr merged 2 commits intoopenSUSE:mainfrom
tomschr merged 2 commits intoopenSUSE:mainfrom
Conversation
tomschr
requested changes
Dec 10, 2025
Contributor
tomschr
left a comment
There was a problem hiding this comment.
This looks good. There is only two lines you forgot in src/docbuild/cli/cmd_cli.py:
diff --git i/src/docbuild/cli/cmd_cli.py w/src/docbuild/cli/cmd_cli.py
index ad98051..6299c5c 100644
--- i/src/docbuild/cli/cmd_cli.py
+++ w/src/docbuild/cli/cmd_cli.py
@@ -14,8 +14,8 @@ from typing import Any, cast
from ..__about__ import __version__
from ..config.app import replace_placeholders
from ..config.load import handle_config
-from ..models.config_model.app import AppConfig
-from ..models.config_model.env import EnvConfig
+from ..models.config.app import AppConfig
+from ..models.config.env import EnvConfigIf you apply these, then my tests succeeds. 😸
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue #109