Merged
Conversation
Coverage ReportFor commit 3220a82 Click to expand Coverage Report Name Stmts Miss Branch BrPart Cover
--------------------------------------------------------------------------------
+ src/docbuild/utils/pidlock.py 79 1 14 1 97.8%
+ src/docbuild/cli/cmd_validate/process.py 178 3 52 2 97.8%
+ src/docbuild/config/xml/stitch.py 48 1 12 1 96.7%
+ src/docbuild/models/path.py 43 1 12 1 96.4%
+ src/docbuild/cli/callback.py 35 0 10 2 95.6%
+ src/docbuild/models/config/env.py 118 5 2 1 95.0%
+ src/docbuild/cli/cmd_metadata/metaprocess.py 157 4 42 7 94.5%
- src/docbuild/cli/cmd_config/__init__.py 9 1 0 0 88.9%
- src/docbuild/cli/cmd_cli.py 84 11 6 3 84.4%
- src/docbuild/cli/cmd_build/__init__.py 13 5 0 0 61.5%
- src/docbuild/cli/cmd_metadata/__init__.py 27 10 2 0 58.6%
- src/docbuild/cli/cmd_config/environment.py 11 6 2 0 38.5%
--------------------------------------------------------------------------------
+ TOTAL 2520 48 594 18 97.8%
44 files skipped due to complete coverage. |
* Introduce ValidationResult datatype * Break down `process_file` into: * `build_shortname`: Return a shortened display name for `filepath`. * `run_validation`: Run RNG validation using the selected method and normalize result. * `parse_tree`: Parse XML file using lxml in a background thread. * `run_checks_and_display`: Execute registered Python checks and print formatted results. * Amend the test file `test_process_validation.py`
tomschr
force-pushed
the
toms/complexity-process_file
branch
from
0874634 to
3220a82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_fileinto:build_shortname: Return a shortened display name forfilepath.run_validation: Run RNG validation using the selected method and normalize result.parse_tree: Parse XML file using lxml in a background thread.run_checks_and_display: Execute registered Python checks and print formatted resultsRelated to #135.