fix: prevent silent failures on invalid placeholder syntax#237
Merged
sushant-suse merged 3 commits intoopenSUSE:mainfrom Apr 29, 2026
Merged
fix: prevent silent failures on invalid placeholder syntax#237sushant-suse merged 3 commits intoopenSUSE:mainfrom
sushant-suse merged 3 commits intoopenSUSE:mainfrom
Conversation
…ders Signed-off-by: sushant-suse <sushant.gaurav@suse.com>
Signed-off-by: sushant-suse <sushant.gaurav@suse.com>
Coverage ReportFor commit cb0f13c Click to expand Coverage Report Name Stmts Miss Branch BrPart Cover
--------------------------------------------------------------------------------
+ src/docbuild/models/deliverable.py 180 1 22 0 99.5%
+ src/docbuild/cli/cmd_check/process.py 58 0 22 1 98.8%
+ src/docbuild/models/manifest.py 111 1 12 1 98.4%
+ src/docbuild/utils/pidlock.py 79 1 14 1 97.8%
+ src/docbuild/cli/cmd_config/list.py 26 0 8 1 97.1%
+ src/docbuild/cli/cmd_validate/process.py 178 5 52 4 96.1%
+ src/docbuild/cli/callback.py 35 0 10 2 95.6%
+ src/docbuild/utils/concurrency.py 69 3 18 1 95.4%
+ src/docbuild/cli/cmd_cli.py 110 3 16 3 95.2%
- src/docbuild/config/xml/stitch.py 47 5 12 0 88.1%
- src/docbuild/cli/cmd_metadata/metaprocess.py 215 26 66 13 82.6%
- src/docbuild/cli/cmd_config/validate.py 21 2 12 3 78.8%
- src/docbuild/cli/cmd_check/__init__.py 18 5 2 0 65.0%
- src/docbuild/cli/cmd_build/__init__.py 13 5 0 0 61.5%
- src/docbuild/cli/cmd_metadata/__init__.py 27 10 2 0 58.6%
--------------------------------------------------------------------------------
+ TOTAL 3068 67 746 30 97.0%
47 files skipped due to complete coverage. |
tomschr
requested changes
Apr 29, 2026
Contributor
tomschr
left a comment
There was a problem hiding this comment.
Great work! 👍 I have only two questions. Maybe you've added two files by accident. I guess you want to remove them. 🙂
Thank you!
Signed-off-by: sushant-suse <sushant.gaurav@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #233
What changed:
Added strict syntax validation for configuration placeholders. The application will now explicitly raise an error when it encounters malformed or orphaned curly braces (like
{server.nameor}} hello {{), instead of silently leaving them unresolved.How it works:
PlaceholderSyntaxError._validate_brace_syntaxto thePlaceholderResolverto track brace pairs mathematically.AppConfigandEnvConfigPydantic models to catch and format the new exception for the CLI.