Add ENABLE_PYTHON3 to the conditional that triggers building bindings#368
Merged
mlschroe merged 1 commit intoopenSUSE:masterfrom Feb 13, 2020
dralley:bindings-fix
Merged
Add ENABLE_PYTHON3 to the conditional that triggers building bindings#368mlschroe merged 1 commit intoopenSUSE:masterfrom dralley:bindings-fix
mlschroe merged 1 commit intoopenSUSE:masterfrom
dralley:bindings-fix
Conversation
Conan-Kudo
approved these changes
Feb 13, 2020
Contributor
Author
Member
|
No objections, but note that you should only use ENABLE_PYTHON3 if you plan to build both the python2 and the python3 bindings. |
Member
|
(That's also why the ENABLE_PYTHON3 option was hidden, it's not meant to be used if you're building for just one python version.) |
Contributor
Author
|
Thanks for the info, I wasn't aware of that. Do you think that still makes sense now that Python 2 is EOL? |
Member
|
I'm fine with adding ENABLE_PYTHON3 to that "if" statement, but I'd prefer to keep ENABLE_PYTHON3 somewhat hidden by not announcing it in an OPTION statement. |
ENABLE_PYTHON3 is used in the CMakeLists.txt in the bindings directory but if it's defined alone it won't trigger building the bindings.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.