Merged
Conversation
|
Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-01-08 14:21:58 UTC |
48fff35 to
41b968b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1463 +/- ##
==========================================
+ Coverage 31.07% 31.25% +0.18%
==========================================
Files 49 49
Lines 17779 17820 +41
==========================================
+ Hits 5524 5570 +46
+ Misses 12255 12250 -5 ☔ View full report in Codecov by Sentry. |
AvengerMoJo
reviewed
Jan 8, 2024
AvengerMoJo
left a comment
There was a problem hiding this comment.
Using this patch in https://src.opensuse.org/alexlau/bash-custom-action/actions/runs/9 container and it is working. Thanks
…r points to /dev/null
Options for apiurls can be set via OSC_HOST_<ALIAS>_<OPTION>=... This requires a configured alias in the config file. Setting the default apiurl via OSC_APIURL=... was working already. Also OSC_CONFIG= / --config= was already implemented to skip loading configuration entirely. Options for the default apiurl can be now set via: OSC_USERNAME=... OSC_CREDENTIALS_MGR_CLASS=... OSC_PASSWORD=... This, for example, makes running osc in containers with credentials stored in environmental variables possible: OSC_CONFIG= OSC_APIURL=<url> OSC_USERNAME=<user> OSC_PASSWORD=<password> osc ...
41b968b to
82216c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.