Better detection of user charset#8
Merged
marcus-h merged 1 commit intoopenSUSE:masterfrom Aug 7, 2012
nijel:master
Merged
Conversation
Using locale.getdefaultlocale() for encoding detection breaks with locales that use modifiers, such as de_DE@euro, or ca_ES@valencia. Use locale.getpreferredencoding() instead, which should do the right thing.
marcus-h
added a commit
that referenced
this pull request
Aug 7, 2012
Better detection of user charset
Member
|
Thanks for the patch! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using locale.getdefaultlocale() for encoding detection breaks with
locales that use modifiers, such as de_DE@euro, or ca_ES@valencia.
Use locale.getpreferredencoding() instead, which should do the right
thing.
Originally reported at http://bugs.debian.org/682261