…mprove error handling ## Security Fixes (CRITICAL) ### Bug #1: Shell Injection in SSH Path Operations - File: src/utils/ssh_deploy/client.rs - Added shell_escape dependency to escape all path parameters - Fixed: create_directory(), file_exists(), directory_exists(), is_package_installed() - Impact: Prevents RCE via malicious paths (e.g., `/tmp/file; rm -rf /`) ### Bug #2: Shell Injection in Systemd Service Commands - File: src/utils/ssh_deploy/services.rs - Added shell escaping for all service names in systemctl commands - Fixed: enable_and_start_service(), enable_service(), await_service_startup() - Impact: Prevents RCE via malicious service names ### Bug #3: Shell Injection in Package Management - File: src/utils/ssh_deploy/client.rs - Package names now properly escaped in dpkg/rpm commands - Impact: Prevents shell injection in package verification ## High-Severity Fixes ### Bug #4: Input Validation Framework - File: src/utils/ssh_deploy/validators.rs (NEW) - Added comprehensive input validation module with 31 unit tests - Functions: validate_remote_path(), validate_service_name(), validate_package_name(), validate_hostname(), validate_port(), validate_system_requirements() - Checks for directory traversal, null bytes, newlines, excessive length ### Bug #5: Resource Cleanup - File: src/utils/ssh_deploy/client.rs - Drop trait already implemented for automatic SSH session cleanup - Verified close() method calls session.disconnect() ### Bug #6: Configurable Connection Timeout - File: src/utils/ssh_deploy/types.rs - Added connection_timeout_secs field to ServerConfig - Defaults to 30 seconds, configurable per deployment - Updated SshClient::new() to use config timeout instead of hardcoded value ### Bug #7: Race Condition Documentation - File: src/utils/ssh_deploy/client.rs - Added comprehensive TOCTOU race condition documentation - Explains risks and mitigation strategies for file_exists() and directory_exists() ### Bug #8: Improved Error Handling - File: src/utils/ssh_deploy/services.rs - Added contextual error messages for sudo command failures - Differentiates between permission issues and missing service files ## Changes - Added shell-escape crate for secure shell argument escaping - Created validators module with 31 unit tests - Enhanced error messages with troubleshooting guidance - Documented inherent race conditions in file checks - Made SSH timeout configurable for slow networks ## Testing - All code compiles successfully (cargo check passing) - 31 validator unit tests included and working - Existing tests updated for new ServerConfig field - Shell escaping verified with special characters ## Security Impact - Eliminates critical remote code execution vulnerabilities - Establishes defensive validation layer for all inputs - Provides detailed error context for troubleshooting - Documents known limitations and risks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

implement sonic rpc setup automation #3

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions