Skip to content

feat: prevent data upload and mutating archived devices#864

Merged
scheidtdav merged 2 commits intodevfrom
feat/make-archived-devices-immutable
Apr 13, 2026
Merged

feat: prevent data upload and mutating archived devices#864
scheidtdav merged 2 commits intodevfrom
feat/make-archived-devices-immutable

Conversation

@jona159
Copy link
Copy Markdown
Contributor

@jona159 jona159 commented Apr 2, 2026

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

  • This PR closes #

@jona159 jona159 linked an issue Apr 2, 2026 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 69.36% 1732 / 2497
🔵 Statements 67.64% 1804 / 2667
🔵 Functions 69.45% 357 / 514
🔵 Branches 56.36% 943 / 1673
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/lib/devices-service.server.ts 57.37% 41.93% 62.5% 56.36% 100, 113-118, 150-151, 161, 170-173, 184-201, 209, 229-234, 252, 270-273, 292-295
app/lib/measurement-service.server.ts 67.21% 66.29% 100% 69.23% 29, 48, 85, 88, 105, 126, 128, 132, 137, 144-146, 158-160, 176-178, 184-186, 193-195, 211-213, 293-300, 308-317
app/models/device.server.ts 65.72% 68.58% 61.11% 66.03% 81-86, 92, 147-148, 217-232, 272, 335, 364, 391, 395, 403-405, 411-413, 429-431, 435-437, 489-595, 646-650, 678-684, 689-705, 784-786, 797, 804-805, 813, 840, 941-961, 980
app/models/measurement.server.ts 50.72% 31.81% 75% 50% 33-158, 183, 184, 193-197, 238-240, 244
app/routes/api.boxes.$deviceId.$sensorId.ts 73.91% 46.15% 100% 73.91% 14-16, 27-29, 52, 61-72
app/routes/api.boxes.$deviceId.data.ts 90% 60.71% 100% 90% 28, 50, 70
Generated in workflow #2346 for commit dc81aa0 by the Vitest Coverage Report Action

@scheidtdav scheidtdav enabled auto-merge (squash) April 13, 2026 12:20
@scheidtdav scheidtdav merged commit 75e772e into dev Apr 13, 2026
6 checks passed
@scheidtdav scheidtdav deleted the feat/make-archived-devices-immutable branch April 13, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prevent data upload for archived devices

2 participants