Conversation
Collaborator
Author
|
Attached are the openapi.json contents (after human-readable reformatting) generated by FastAPI after the above commit (9d40424) from the current HEAD of the master branch (commit 856d94d): From visually scrolling through every line of the diff between these two files, I have confirmed that no API routes have been lost with the above refactoring. |
Collaborator
Author
|
I haven't tested every single API endpoint, but I've tested things overall and they all seem to work. So I'm going to merge this PR now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR groups the HTTP routes (for static assets, for the GUI, and for the API) for easier reverse-proxying.
TODOs:
/to/imswitchfor easier reverse-proxying/imswitch/index.htmlto/ui/index.html, so that the full URL path is/imswitch/ui/index.html/api, so that the full URL paths all begin with/imswitch/api/imswitch/api/docs/imswitch/libs/*(e.g. for imjoy) are updated appropriatelyThis work is tracked on Notion at https://www.notion.so/Reverse-proxy-ImSwitch-on-port-80-via-our-ingress-proxy-28a4e612c78a80b6a78ce8938edaacd1?source=copy_link