Refactor objective position validation and improve UI layout for bett…#282
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is primarily a formatting/readability refactor of the ObjectiveController.js React component, reflowing long lines and JSX into multi-line forms. It also makes two small functional/UI tweaks: removing the "Objective Controller" heading and changing the container/live-view sizing to use full width instead of fixed max dimensions.
Changes:
- Reformat multi-condition checks, arrow functions, and JSX props/children across the component for readability.
- Widen the root
Papertowidth: 100%/maxWidth: 100%and remove theLiveViewControlWrapperwrapper'smaxWidth/maxHeight/overflow/backgroundstyling. - Remove the
<Typography variant="h5">Objective Controller</Typography>heading and clean up minor whitespace (e.g., trailing spaces on</Button>, double spaces inhandleSwitchObjective(1, true )).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Franzili
pushed a commit
that referenced
this pull request
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er readability