Skip to content

Refactor objective position validation and improve UI layout for bett…#282

Merged
gokugiant merged 1 commit into
masterfrom
fix/objective-controller-full-width
May 27, 2026
Merged

Refactor objective position validation and improve UI layout for bett…#282
gokugiant merged 1 commit into
masterfrom
fix/objective-controller-full-width

Conversation

@gokugiant
Copy link
Copy Markdown
Contributor

…er readability

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is primarily a formatting/readability refactor of the ObjectiveController.js React component, reflowing long lines and JSX into multi-line forms. It also makes two small functional/UI tweaks: removing the "Objective Controller" heading and changing the container/live-view sizing to use full width instead of fixed max dimensions.

Changes:

  • Reformat multi-condition checks, arrow functions, and JSX props/children across the component for readability.
  • Widen the root Paper to width: 100% / maxWidth: 100% and remove the LiveViewControlWrapper wrapper's maxWidth/maxHeight/overflow/background styling.
  • Remove the <Typography variant="h5">Objective Controller</Typography> heading and clean up minor whitespace (e.g., trailing spaces on </Button>, double spaces in handleSwitchObjective(1, true )).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gokugiant gokugiant added this pull request to the merge queue May 27, 2026
Merged via the queue into master with commit 4f529bb May 27, 2026
14 checks passed
@gokugiant gokugiant deleted the fix/objective-controller-full-width branch May 27, 2026 09:33
Franzili pushed a commit that referenced this pull request May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants