Simplify nResponses calculation in Motor class #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced multiple type checks for axisToMove with a single calculation using the length of payload['motor'] to determine nResponses. This streamlines the code and improves maintainability.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to simplify the nResponses calculation in the move_stepper method by replacing multiple type checks with a single calculation. However, the implementation contains a critical bug that will cause incorrect behavior.
Key Change
- Replaced conditional type checking of
axisToMovewithlen(payload["motor"])to calculatenResponses
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced multiple type checks for axisToMove with a single calculation using the length of payload['motor'] to determine nResponses. This streamlines the code and improves maintainability.