Support re-enabling remote assistance without a device auth key #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to openUC2/rpi-imswitch-os
that referenced
this pull request
Jan 20, 2026
This PR configures NetworkManager to always try to acquire link-local IPv4 addresses (`169.254.x.y/16`) on its direct connections to other devices, so that they can be used in the following cases: - ~If an RPi is trying to get an IP address via DHCP but the request times out, then the RPi might be able to get internet access via the link-local address as a fallback~ (I tested this and it didn't work, so I've removed it from this PR) - If multiple RPis are connected to the same computer, their statically-assigned IP addresses will conflict but they'll still be accessible via their link-local addresses (though mDNS probably won't use those link-local addresses instead, so an IP address scanner would be needed to discover the devices on their link-local addresses) In other words, here the link-local addresses are a last-resort escape hatch for still being able to access the RPi even if things have gone very wrong. This PR also stops trying to acquire static IP addresses on connections which use DHCP for dynamic IP address assignment, because then DHCP fails if the network on the other end already uses that static IP address. This was a bug I discovered in testing, and things seem to work fine after removal. This PR also bumps the device-admin ctr img to integrate openUC2/device-admin#27, openUC2/device-admin#28, and openUC2/device-admin#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on 0b7db62 by properly supporting the use-case of re-enabling remote assistance on a device which had previously already been added to a network with a device auth key. Now, it works correctly for the user to press the "Enable" button without having to set a new device auth key in that situation. This is equivalent to simply running the
tailscale upcommand on a device.