Allow setting firewall zone in advanced NM conn profile editor#45
Merged
Allow setting firewall zone in advanced NM conn profile editor#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the "firewall zone" field in the advanced NetworkManager connection profile editor from an uneditable piece of text to an editable input field. This can be used to persistently adjust the firewall setting for the wlan1-internet (and wlan0-internet) conn profiles; however, a future PR will be required for persistently adjusting firewall settings for the eth0-default and eth1-default connection profiles either by directly editing NM connection profile drop-in snippets or by directly adjusting Forklift pallet feature flags.
This work is tracked on Notion at https://www.notion.so/Add-GUI-to-adjust-firewall-zones-3364e612c78a80179e43c99497d98930?source=copy_link .