Skip to content

changed info texts#2610

Merged
LKuemmel merged 2 commits intoopenWB:masterfrom
therobbot:Better-messages
Jul 30, 2025
Merged

changed info texts#2610
LKuemmel merged 2 commits intoopenWB:masterfrom
therobbot:Better-messages

Conversation

@therobbot
Copy link
Contributor

modified some of the info texts to make them clearer

if cp.data.get.charge_state:
Pub().pub(
f"openWB/set/chargepoint/{cp.num}/get/state_str", "Lädt... ")
f"openWB/set/chargepoint/{cp.num}/get/state_str", "Ladung aktiv")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
f"openWB/set/chargepoint/{cp.num}/get/state_str", "Ladung aktiv")
f"openWB/set/chargepoint/{cp.num}/get/state_str", "Lädt...")

Nach Rücksprache mit dem Support soll dieser Text beibehalten werden. Die anderen Vorschläge sind gut.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... ich finde halt "Lädt..." sieht danach aus, dass der Info-Text gerade geladen wird. Vor allem wegen der drei Punkte.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, dann Fahrzeug lädt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muss ich das jetzt bei mir ändern und dann den Pull-Request nochmal neu stellen oder kann ich den Vorschlag "Fahrzeug lädt." irgendwie direkt annehmen? Ich bin noch total ungeübt mit Github.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe versucht, das zu ändern, bin aber nicht sicher, ob das jetzt geklappt hat.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hat geklappt

@LKuemmel LKuemmel linked an issue Jul 30, 2025 that may be closed by this pull request
@therobbot therobbot requested a review from LKuemmel July 30, 2025 08:38
@therobbot
Copy link
Contributor Author

Sorry, ich habe aus Versehen glaube ich nochmal das gleiche hochgeladen. Ich bin noch total neu mit Github.

Changed active chargint message
@LKuemmel LKuemmel merged commit 90b77c7 into openWB:master Jul 30, 2025
1 check passed
@therobbot therobbot deleted the Better-messages branch July 30, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missverständliche Info-Texte

2 participants