Skip to content

retry evse readout in case of error: review #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 2 commits into from
Mar 10, 2026
Merged

retry evse readout in case of error: review #3192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa0a93c
retry evse readout in case of error: review
LKuemmel Mar 10, 2026
0e2ae55
pytest
LKuemmel Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions packages/modules/common/hardware_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@


EVSE_MIN_FIRMWARE = 7
MAX_ATTEMPTS = 3
RETRY_DELAY_SECONDS = 0.3

OPEN_TICKET = (" Bitte nehme bei anhaltenden Problemen über die Support-Funktion in den Einstellungen Kontakt mit " +
"uns auf.")
Expand Down Expand Up @@ -84,19 +86,21 @@ def request_and_check_hardware(self: ClientHandlerProtocol,
evse_check_passed = False
evse_state: EvseState
# 2x Retry bei EVSE-Auslesen vor dem Absetzen einer Fehlermeldung
for attempt in (1, 2, 3):
try:
with self.client:
evse_state = self.evse_client.get_evse_state()
evse_check_passed = True
break
except Exception as e:
evse_check_passed = self.handle_exception(e)
# Wenn nicht "handled" -> maximal zwei Wiederholungen
if attempt < 3 and evse_check_passed is False:
time.sleep(0.3)
continue
break
try:
with self.client:
for attempt in range(MAX_ATTEMPTS):
try:
evse_state = self.evse_client.get_evse_state()
evse_check_passed = True
break
except (pymodbus.exceptions.ModbusIOException,
pymodbus.exceptions.ConnectionException) as e:
evse_check_passed = self.handle_exception(e)
# nur warten, wenn danach noch ein Versuch folgt
if attempt < MAX_ATTEMPTS - 2 and evse_check_passed is False:
time.sleep(RETRY_DELAY_SECONDS)
except Exception as e:
evse_check_passed = self.handle_exception(e)
meter_check_passed, meter_error_msg, counter_state = self.check_meter()
if meter_check_passed is False and evse_check_passed is False:
if isinstance(self.client, ModbusTcpClient_):
Expand Down