Skip to content

Fix odometer issue in cupra and skoda SoC modules #3253

Merged
LKuemmel merged 7 commits intoopenWB:masterfrom
vuffiraa72:fix-vwgroup-odometer
Mar 31, 2026
Merged

Fix odometer issue in cupra and skoda SoC modules #3253
LKuemmel merged 7 commits intoopenWB:masterfrom
vuffiraa72:fix-vwgroup-odometer

Conversation

@vuffiraa72
Copy link
Copy Markdown
Contributor

Skoda Modul meldet Fehler "zu viele Parameter" durch die gemeinsam mit VWID benutzte vwgroup library.
Dasselbe tritt auch bei Cupra auf.
Der PR ergänzt den fehlenden Parameter für beide Module.
Siehe https://forum.openwb.de/viewtopic.php?p=141495#p141495

@vuffiraa72 vuffiraa72 changed the title Fix vwgroup odometer Fix odometer issue in cupra and skoda SoC modules Mar 29, 2026
@LKuemmel LKuemmel requested a review from Copilot March 30, 2026 08:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a runtime mismatch between VWGroup’s SoC data shape and the Skoda/Cupra SoC modules by adding odometer support end-to-end, preventing the “zu viele Parameter” error and enriching the returned vehicle state with mileage.

Changes:

  • Update Skoda and Cupra SoC fetch paths to handle and persist the additional odometer value.
  • Extend Skoda and Cupra API libraries to fetch and expose odometer (Skoda via maintenance report; Cupra via mileage endpoint).
  • Update/introduce unit tests to validate odometer propagation and the additional API calls.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/modules/vehicles/skoda/soc.py Unpacks/returns odometer in CarState.
packages/modules/vehicles/skoda/api.py Returns the additional odometer value from fetch_soc.
packages/modules/vehicles/skoda/libskoda.py Adds maintenance report call to populate odometer; improves 403 fallback behavior.
packages/modules/vehicles/skoda/soc_test.py Updates tests for 5-tuple SoC return and odometer in status.
packages/modules/vehicles/cupra/soc.py Unpacks/returns odometer in CarState.
packages/modules/vehicles/cupra/api.py Returns the additional odometer value from fetch_soc.
packages/modules/vehicles/cupra/libcupra.py Adds mileage endpoint call and injects odometer into returned status payload.
packages/modules/vehicles/cupra/soc_test.py Adds coverage for odometer propagation and mileage error behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@LKuemmel LKuemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte die Kommentare von Copilot beachten.

@vuffiraa72 vuffiraa72 requested a review from LKuemmel March 30, 2026 15:46
@LKuemmel LKuemmel merged commit c26d3c1 into openWB:master Mar 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants