Fix odometer issue in cupra and skoda SoC modules #3253
Merged
LKuemmel merged 7 commits intoopenWB:masterfrom Mar 31, 2026
Merged
Fix odometer issue in cupra and skoda SoC modules #3253LKuemmel merged 7 commits intoopenWB:masterfrom
LKuemmel merged 7 commits intoopenWB:masterfrom
Conversation
…test for fallback to charging URL on 403 response
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a runtime mismatch between VWGroup’s SoC data shape and the Skoda/Cupra SoC modules by adding odometer support end-to-end, preventing the “zu viele Parameter” error and enriching the returned vehicle state with mileage.
Changes:
- Update Skoda and Cupra SoC fetch paths to handle and persist the additional
odometervalue. - Extend Skoda and Cupra API libraries to fetch and expose odometer (Skoda via maintenance report; Cupra via mileage endpoint).
- Update/introduce unit tests to validate odometer propagation and the additional API calls.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/modules/vehicles/skoda/soc.py | Unpacks/returns odometer in CarState. |
| packages/modules/vehicles/skoda/api.py | Returns the additional odometer value from fetch_soc. |
| packages/modules/vehicles/skoda/libskoda.py | Adds maintenance report call to populate odometer; improves 403 fallback behavior. |
| packages/modules/vehicles/skoda/soc_test.py | Updates tests for 5-tuple SoC return and odometer in status. |
| packages/modules/vehicles/cupra/soc.py | Unpacks/returns odometer in CarState. |
| packages/modules/vehicles/cupra/api.py | Returns the additional odometer value from fetch_soc. |
| packages/modules/vehicles/cupra/libcupra.py | Adds mileage endpoint call and injects odometer into returned status payload. |
| packages/modules/vehicles/cupra/soc_test.py | Adds coverage for odometer propagation and mileage error behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LKuemmel
requested changes
Mar 30, 2026
Contributor
LKuemmel
left a comment
There was a problem hiding this comment.
Bitte die Kommentare von Copilot beachten.
…fix mileage URL variable name
LKuemmel
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skoda Modul meldet Fehler "zu viele Parameter" durch die gemeinsam mit VWID benutzte vwgroup library.
Dasselbe tritt auch bei Cupra auf.
Der PR ergänzt den fehlenden Parameter für beide Module.
Siehe https://forum.openwb.de/viewtopic.php?p=141495#p141495