Merged
Conversation
Contributor
benderl
commented
Apr 22, 2026
benderl
commented
- tweak apt configuration for default actions
- add missed checks for active user management
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts system behavior around package management defaults and MQTT user/ACL management when “user management” is disabled, aligning runtime behavior with the configured security mode.
Changes:
- Guard ACL role removal for vehicles behind
security.user_management_active. - Guard external chargepoint display-user updates on IP changes behind
security.user_management_active(and fix a comment typo). - Update APT config version and add dpkg default options to keep existing config files during upgrades.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/helpermodules/subdata.py |
Adds missing user_management_active checks before mutating mosquitto dynsec roles/users. |
data/config/apt/99openwb |
Bumps openwb-version and adds dpkg options for default conffile handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.