chore(helm): migrate chart tests to helm-unittest

[thepagent]

Summary

The current Helm chart tests use bash scripts with helm template + grep assertions (e.g., tests/helm-template-test.sh). This works but is fragile — grep-based assertions break easily with formatting changes and have no structured access to YAML fields.

Proposal

Migrate to helm-unittest, the de facto standard for Helm chart testing. Benefits:

• Declarative YAML tests — no bash scripting
• Structured assertions — JSON path access to rendered YAML, no fragile grep
• Snapshot testing — catch unexpected template changes automatically
• Better CI integration — JUnit XML output, easy to plug into any CI pipeline

Example

Current (bash):

OUT=$(helm template test "$CHART_DIR" --set "agents.kiro.discord.enabled=true" 2>&1)
if echo "$OUT" | grep -q "^\[discord\]"; then
  pass "[discord] section rendered"
else
  fail "[discord] section missing"
fi

Proposed (helm-unittest):

suite: adapter enablement
templates:
  - templates/configmap.yaml
tests:
  - it: renders [discord] when enabled
    set:
      agents.kiro.discord.enabled: true
    asserts:
      - contains:
          path: data["config.toml"]
          content: "[discord]"

Migration steps

1. helm plugin install https://github.com/helm-unittest/helm-unittest
2. Convert existing tests/helm-template-test.sh cases to YAML under tests/
3. Convert tests/helm-adapter-enablement-test.sh cases
4. Update CI to run helm unittest charts/openab
5. Remove old bash scripts

Context

• Current tests: charts/openab/tests/helm-template-test.sh, charts/openab/tests/helm-adapter-enablement-test.sh
• Related: [Bug] [Helm] Helm chart 0.7.7-beta.1: [discord] section in config.toml depends on botToken being set at render time #392, fix(helm): decouple [discord] section from botToken presence #403

[github-actions]

Thanks for the report! It looks like this issue was created without a template and is missing some required fields. Please add one of the following labels: bug, feature, documentation, or guidance, then edit this issue to include the matching template fields — the incomplete label will be removed automatically.

[thepagent]

Additional follow-up: CI currently does not run any helm tests. ci.yml only triggers on src/** / Cargo.* / Dockerfile* — changes under charts/ are not tested.

As part of this migration, we should also add a CI job:

# ci.yml
on:
  pull_request:
    paths:
      - "charts/**"

jobs:
  helm-test:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v6
      - uses: azure/setup-helm@v4
      - run: helm plugin install https://github.com/helm-unittest/helm-unittest
      - run: helm unittest charts/openab

Ref: #403 added the first helm-unittest tests but they are not wired into CI yet.