fix: handle duplicate thread creation on Discord gateway reconnect#137
Open
the3mi wants to merge 1 commit intoopenabdev:mainfrom
Open
fix: handle duplicate thread creation on Discord gateway reconnect#137the3mi wants to merge 1 commit intoopenabdev:mainfrom
the3mi wants to merge 1 commit intoopenabdev:mainfrom
Conversation
When Discord gateway reconnects, the same message event can be delivered twice. The second attempt to create a thread fails with HTTP 500 because the thread already exists. This change catches the HTTP 500 error and queries the channel to find the existing thread, returning its ID instead of propagating the error.
Author
|
👋 This fix is ready to merge and resolves the exact error currently affecting production: The fix is minimal and safe — it only changes the error handler for thread creation to query existing threads instead of propagating the error. No behavior change for the happy path. Could we get an expedited review? This is blocking production use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Discord gateway reconnects, the same message event can be delivered twice. The second attempt to create a thread fails with HTTP 500 because the thread already exists.
This change catches the HTTP 500 error and queries the channel to find the existing thread, returning its ID instead of propagating the error.
Fixes:
A thread has already been created for this messageerror on gateway reconnect.