fix: remove trailing comma in TOML inline table#196
Merged
thepagent merged 1 commit intoopenabdev:mainfrom Apr 11, 2026
Merged
Conversation
chaodu-agent
approved these changes
Apr 11, 2026
Collaborator
chaodu-agent
left a comment
There was a problem hiding this comment.
LGTM 👍 乾淨俐落的 one-liner fix,解決 TOML trailing comma 導致 pod crash loop 的問題。
thepagent
approved these changes
Apr 11, 2026
pahud
pushed a commit
that referenced
this pull request
Apr 11, 2026
Co-authored-by: JARVIS-coding-Agent <jarvis@openab.dev>
Reese-max
pushed a commit
to Reese-max/openab
that referenced
this pull request
Apr 12, 2026
Co-authored-by: JARVIS-coding-Agent <jarvis@openab.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #195
Problem
The Go template
rangeloop inconfigmap.yamlappends a trailing comma after every key-value pair in the TOML inline table:TOML does not allow trailing commas in inline tables, causing parser errors and pod crash loops.
Fix
Use a
$firstflag to insert commas only between items, not after the last one.