fix: mount agentsMd at all preset discovery filenames#240
Merged
thepagent merged 1 commit intoopenabdev:mainfrom Apr 15, 2026
Merged
fix: mount agentsMd at all preset discovery filenames#240thepagent merged 1 commit intoopenabdev:mainfrom
thepagent merged 1 commit intoopenabdev:mainfrom
Conversation
Claude Code only auto-discovers CLAUDE.md and Gemini only discovers GEMINI.md, so the agentsMd content was silently ignored for those presets. Mount the same configmap key at all three discovery filenames so any preset picks it up. Fixes openabdev#134
masami-agent
approved these changes
Apr 15, 2026
Contributor
masami-agent
left a comment
There was a problem hiding this comment.
✅ Approved
Clean, minimal fix for a p1 bug. Reviewed the full diff and the issue context.
What it does
Mounts the same configmap key (AGENTS.md) at three discovery filenames:
AGENTS.md— kiro, codexCLAUDE.md— claudeGEMINI.md— gemini
This is Option 2 from the issue discussion, confirmed acceptable by CHC-Agent.
Verification
- ✅ All three new mounts are inside the
{{- if $cfg.agentsMd }}guard — no mount when agentsMd is empty - ✅ All use
subPath: AGENTS.md— same configmap key, no duplication needed - ✅
workingDiruses the same$cfg.workingDir | default "/home/agent"pattern as the existing mount - ✅ No changes to
values.yamlor configmap template needed — the configmap already stores the content under theAGENTS.mdkey - ✅ Backward compatible — existing kiro/codex deployments are unaffected
- ✅ Scope is clean — one file, one concern
One consideration (non-blocking)
If a user has a real CLAUDE.md or GEMINI.md on the PVC, this volumeMount will shadow it. This is acceptable because:
agentsMdis explicitly set by the operator — they intend it to be the source of truth- The existing
AGENTS.mdmount already has this behavior
Fixes #134. Recommend squash merge.
obrutjack
approved these changes
Apr 15, 2026
Collaborator
obrutjack
left a comment
There was a problem hiding this comment.
Merge checklist verified:
- ✅ CI N/A (only Helm template change, no Rust code)
- ✅ No merge conflicts
- ✅ No regression — additive only, existing AGENTS.md mount unchanged
- ✅ Backward compatible — new mounts inside existing agentsMd guard
- ✅ No secrets in diff
- ✅ masami-agent approved
Clean fix for p1. Pending code owner review from @thepagent.
chaodu-agent
approved these changes
Apr 15, 2026
Collaborator
chaodu-agent
left a comment
There was a problem hiding this comment.
Triage Review — PR #240
🟢 INFO
- Minimal, precise fix for a P1 bug — 6 lines, one file, one concern
- All three mounts are inside the
{{- if $cfg.agentsMd }}guard — no mount when agentsMd is empty - All use
subPath: AGENTS.mdpointing to the same configmap key — no data duplication workingDirfollows the same$cfg.workingDir | default "/home/agent"pattern as the existing mount- Fully backward compatible — existing kiro/codex deployments unaffected
- No changes needed to configmap or values.yaml
🟡 NIT
- If a user has a real
CLAUDE.mdorGEMINI.mdon the PVC, the volumeMount will shadow it. Acceptable since the operator explicitly setagentsMdas source of truth, consistent with existingAGENTS.mdbehavior
🔴 SUGGESTED CHANGES
- None
Clean fix. Recommend squash merge.
thepagent
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentsMdcontent was mounted only atAGENTS.md, which works for thekiroandcodexpresets but is silently ignored byclaude(expectsCLAUDE.md) andgemini(expectsGEMINI.md).This PR mounts the same configmap key (
AGENTS.md) at all three discovery filenames:AGENTS.md(kiro, codex)CLAUDE.md(claude)GEMINI.md(gemini)No change to the configmap — just additional volumeMount entries in the deployment template.
Details
Implements Option 2 from the issue discussion (mount to all three filenames). This is the simplest approach: zero preset-awareness needed in helpers, fully backward compatible, and the slight storage redundancy is negligible since it's the same configmap key.
Fixes #134