fix: resolve mentions instead of stripping all (#363)#364
Merged
thepagent merged 3 commits intoopenabdev:mainfrom Apr 15, 2026
Merged
fix: resolve mentions instead of stripping all (#363)#364thepagent merged 3 commits intoopenabdev:mainfrom
thepagent merged 3 commits intoopenabdev:mainfrom
Conversation
Replace strip_mention with resolve_mentions so only the bot's own trigger mention is removed. All other <@id> tokens are resolved to @DisplayName using msg.mentions, preserving bot-to-bot @mention visibility.
github-actions
bot
added
closing-soon
added 2 commits
April 15, 2026 18:00
thepagent
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #363.
strip_mentionused a blanket regex (<@[!&]?\d+>) that removed all Discord mention tokens from the prompt — including references to other bots/users. This broke bot-to-bot collaboration introduced in v0.7.4.Changes
Replace
strip_mentionwithresolve_mentions(content, bot_id, mentions):<@BOT_ID>is removed<@ID>to@DisplayName— usingmsg.mentionsfrom serenityBefore
After
Approach
Follows the same pattern as OpenClaw's
resolveDiscordMentions— never strip, always resolve.https://discord.com/channels/1491295327620169908/1494031440482926706