Skip to content

fix(helm): handle nil cfg in agentFullname for NOTES.txt compatibility#500

Merged
thepagent merged 1 commit intomainfrom
fix/agent-fullname-nil-cfg
Apr 20, 2026
Merged

fix(helm): handle nil cfg in agentFullname for NOTES.txt compatibility#500
thepagent merged 1 commit intomainfrom
fix/agent-fullname-nil-cfg

Conversation

@thepagent
Copy link
Copy Markdown
Collaborator

Description

Fix nil pointer panic in openab.agentFullname when called without cfg in the template dict (e.g. from NOTES.txt).

Steps to Reproduce

helm install with nameOverride set — NOTES.txt calls agentFullname with dict "ctx" $ "agent" $name (no cfg), causing a nil dereference.

Fix

Guard .cfg.nameOverride with a nil check on .cfg first:

{{- if and .cfg (.cfg.nameOverride) (ne .cfg.nameOverride "") }}

@thepagent thepagent added bug Something isn't working helm labels Apr 20, 2026
@github-actions github-actions Bot added the closing-soon PR missing Discord Discussion URL — will auto-close in 3 days label Apr 20, 2026
@github-actions
Copy link
Copy Markdown

⚠️ This PR is missing a Discord Discussion URL in the body.

All PRs must reference a prior Discord discussion to ensure community alignment before implementation.

Please edit the PR description to include a link like:

Discord Discussion URL: https://discord.com/channels/...

This PR will be automatically closed in 3 days if the link is not added.

@thepagent thepagent merged commit e7e0003 into main Apr 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working closing-soon PR missing Discord Discussion URL — will auto-close in 3 days helm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant