fix: gate Unix-only libc calls in connection.rs for Windows builds#563
Merged
fix: gate Unix-only libc calls in connection.rs for Windows builds#563
Conversation
pre_exec/setpgid and kill/SIGTERM/SIGKILL are Unix-only APIs. Wrap them with #[cfg(unix)] and add #[cfg(windows)] branch using CREATE_NEW_PROCESS_GROUP for Windows process group management.
github-actions
Bot
added
the
closing-soon
|
All PRs must reference a prior Discord discussion to ensure community alignment before implementation. Please edit the PR description to include a link like: This PR will be automatically closed in 3 days if the link is not added. |
thepagent
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #562. The
libcdependency was gated to Unix-only inCargo.toml, butconnection.rsstill had unguardedlibc::kill(),libc::setpgid(), andpre_exec()calls that fail on Windows.Changes
pre_exec+setpgidblock with#[cfg(unix)]#[cfg(windows)]branch usingcreation_flags(CREATE_NEW_PROCESS_GROUP)kill_process_groupbody with#[cfg(unix)]CommandExtTesting
cargo build✅, 121 tests pass ✅