refactor(discord): extract build_sender_context + ChannelRef.parent_id + doc comments#587
Merged
thepagent merged 1 commit intoopenabdev:mainfrom Apr 26, 2026
Conversation
….parent_id + doc comments - Extract build_sender_context() pure function from EventHandler::message for testability, with 3 unit tests covering in-thread, non-thread, and bot sender scenarios (openabdev#584) - Populate ChannelRef.parent_id when in a Discord thread, so downstream consumers have complete context. channel_id remains the thread's own channel ID for routing (openabdev#585) - Add doc comments to ChannelRef and SenderContext in adapter.rs clarifying the semantic difference: ChannelRef.channel_id is for routing (send to), SenderContext.channel_id is metadata for agent (came from) (openabdev#586) Closes openabdev#584, closes openabdev#585, closes openabdev#586
github-actions
Bot
added
pending-screening
|
All PRs must reference a prior Discord discussion to ensure community alignment before implementation. Please edit the PR description to include a link like: This PR will be automatically closed in 3 days if the link is not added. |
thepagent
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up from PR #583 review. Implements three improvements identified by the monk review team:
1. Extract
build_sender_context()pure function (#584)The
SenderContextassembly logic was embedded insideEventHandler::message(), making it impossible to unit test without mocking serenity. Extracted as a pure function (same pattern asdetect_thread()) with 3 table-driven tests:channel_id= parent,thread_id= Some(thread)channel_id= channel,thread_id= Noneis_botflag propagated correctly2. Populate
ChannelRef.parent_idfor Discord threads (#585)When a message is inside a Discord thread, the
thread_channelChannelRef now carriesparent_id.channel_idremains the thread's own channel ID (required for routing).3. Doc comments clarifying
SenderContextvsChannelRefsemantics (#586)Added doc comments to both structs in
adapter.rsexplaining:ChannelRef= routing (channel_idis where to send messages)SenderContext= metadata for agent (channel_idis the parent channel)Testing
build_sender_context()References
Closes #584, closes #585, closes #586
Follow-up from #583 (merged)