Skip to content

fix(helm): add missing gateway permission fields in ConfigMap #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thepagent merged 3 commits into from
May 1, 2026
+20 −6
Merged

fix(helm): add missing gateway permission fields in ConfigMap #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27f4342
fix(helm): add gateway permissions and improve template robustness
iamninihuang Apr 30, 2026
7c5a478
fix: remove duplicate botUsername block in configmap.yaml
chaodu-agent May 1, 2026
6799ae8
fix: escape regex in regexMatch to fix Helm template parse error
chaodu-agent May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions charts/openab/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,22 @@ Agents deployed:
Required scopes: app_mentions:read, chat:write, channels:history, groups:history, channels:read, groups:read, reactions:write, files:read
{{- end }}

{{- if eq $cfg.command "kiro-cli" }}
{{- if eq (toString $cfg.command) "kiro-cli" }}
Authenticate:
kubectl exec -it deployment/{{ include "openab.agentFullname" (dict "ctx" $ "agent" $name) }} -- kiro-cli login --use-device-flow
{{- else if eq $cfg.command "codex-acp" }}
{{- else if eq (toString $cfg.command) "codex-acp" }}
Authenticate:
kubectl exec -it deployment/{{ include "openab.agentFullname" (dict "ctx" $ "agent" $name) }} -- codex login --device-auth
{{- else if eq $cfg.command "claude-agent-acp" }}
{{- else if eq (toString $cfg.command) "claude-agent-acp" }}
Authenticate:
kubectl exec -it deployment/{{ include "openab.agentFullname" (dict "ctx" $ "agent" $name) }} -- claude setup-token
{{- else if eq $cfg.command "gemini" }}
{{- else if eq (toString $cfg.command) "gemini" }}
Authenticate:
kubectl exec -it deployment/{{ include "openab.agentFullname" (dict "ctx" $ "agent" $name) }} -- gemini
{{- else if eq $cfg.command "opencode" }}
{{- else if eq (toString $cfg.command) "opencode" }}
Authenticate:
kubectl exec -it deployment/{{ include "openab.agentFullname" (dict "ctx" $ "agent" $name) }} -- opencode auth login
{{- else if eq $cfg.command "cursor-agent" }}
{{- else if eq (toString $cfg.command) "cursor-agent" }}
Authenticate:
kubectl exec -it deployment/{{ include "openab.agentFullname" (dict "ctx" $ "agent" $name) }} -- cursor-agent login
{{- end }}
Expand Down
14 changes: 14 additions & 0 deletions charts/openab/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,20 @@ data:
{{- if ($cfg.gateway).botUsername }}
bot_username = {{ ($cfg.gateway).botUsername | toJson }}
{{- end }}
allow_all_channels = {{ if and (hasKey ($cfg.gateway) "allowAllChannels") (ne ($cfg.gateway).allowAllChannels nil) }}{{ ($cfg.gateway).allowAllChannels }}{{ else if ($cfg.gateway).allowedChannels }}false{{ else }}true{{ end }}
{{- range ($cfg.gateway).allowedChannels }}
{{- if regexMatch "[eE]\\+" (toString .) }}
{{- fail (printf "gateway.allowedChannels contains a mangled ID: %s — use --set-string instead of --set for channel IDs" (toString .)) }}
{{- end }}
{{- end }}
allowed_channels = {{ ($cfg.gateway).allowedChannels | default list | toJson }}
allow_all_users = {{ if and (hasKey ($cfg.gateway) "allowAllUsers") (ne ($cfg.gateway).allowAllUsers nil) }}{{ ($cfg.gateway).allowAllUsers }}{{ else if ($cfg.gateway).allowedUsers }}false{{ else }}true{{ end }}
{{- range ($cfg.gateway).allowedUsers }}
{{- if regexMatch "[eE]\\+" (toString .) }}
{{- fail (printf "gateway.allowedUsers contains a mangled ID: %s — use --set-string instead of --set for user IDs" (toString .)) }}
{{- end }}
{{- end }}
allowed_users = {{ ($cfg.gateway).allowedUsers | default list | toJson }}
{{- end }}
{{- if or ($cfg.cronjobs) (($cfg.cron).usercronEnabled) (($cfg.cron).usercronPath) }}

Expand Down
Loading