feat(chart): expose maxBotTurns for Slack/Discord#671
Merged
Conversation
Wires the existing Rust max_bot_turns config field through the Helm chart so deployers can set the soft cap from chart values. - configmap.yaml: gated blocks for Discord and Slack - values.yaml: commented maxBotTurns placeholder with docs - docs/messaging.md: Helm chart example section Co-authored-by: 超渡法師 <chaodu@openab.dev> Closes #609
github-actions
Bot
added
closing-soon
Covers: - Discord maxBotTurns renders max_bot_turns = N - Slack maxBotTurns renders max_bot_turns = N - Unset maxBotTurns does not render max_bot_turns line Addresses review feedback from 擺渡法師.
github-actions
Bot
removed
the
closing-soon
thepagent
approved these changes
May 1, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #609. Supersedes #610.
Discord Discussion: https://discord.com/channels/1491295327620169908/1491365157010542652/1498547660540608602
Summary
Takes over @dogzzdogzz's work from #610 — rebased onto latest main, resolved conflict with the new
allowDmblock, and fixed ordering nit (maxBotTurnsnow comes afterallowDmin the Discord section).What changed
charts/openab/templates/configmap.yaml— gatedmax_bot_turnsblocks for Discord and Slack, usinghasKeyguard pattern. Discord block placed afterallowDm(behavior knobs grouping).charts/openab/values.yaml— commentedmaxBotTurnsplaceholder under both Discord and Slack defaults, with doc-comment noting default 20 and hard cap 100.docs/messaging.md— Helm chart example section showingvalues.yamlequivalent of theconfig.tomlkeys.charts/openab/tests/configmap_test.yaml— 3 new test cases: Discord render, Slack render, unset does not render.What did not change
src/config.rsfield, samesrc/bot_turns.rssemantics.config.tomlis byte-for-byte identical whenmaxBotTurnsis unset.Changes vs #610
allowDmblock)maxBotTurnsblock placed afterallowDm(was before in feat(chart): expose maxBotTurns for Slack and Discord adapters #610 due to conflict)Credit
Original implementation by @dogzzdogzz. Taken over with nit fixes by 超渡法師.