fix(config): correct working_dir for non-Kiro agents#756
Conversation
|
All PRs must reference a prior Discord discussion to ensure community alignment before implementation. Please edit the PR description to include a link like: This PR will be automatically closed in 3 days if the link is not added. |
OpenAB PR ScreeningThis is auto-generated by the OpenAB project-screening flow for context collection and reviewer handoff.
Screening report## IntentPR #756 corrects the example agent configuration so non-Kiro backends use the right container home/workspace path. The operator-visible problem is that FeatThis is a configuration fix. It updates
Who It ServesPrimary beneficiary: deployers and agent runtime operators. Secondary beneficiaries: maintainers and reviewers, because the example config becomes a more reliable source of truth for backend-specific runtime assumptions. Rewritten PromptFix Keep Verify the example config remains valid TOML and that path changes are limited to the affected backend examples. Merge PitchThis is worth advancing because it fixes a misleading example that can directly break real deployments copied from the repository. The blast radius is low: one example config file, no runtime code path, and a clear backend-specific rationale. Likely reviewer concern: whether Best-Practice ComparisonFor this PR, only a subset of the OpenClaw and Hermes Agent principles are relevant. OpenClaw relevance:
Hermes Agent relevance:
The best-practice alignment here is mostly about making runtime environment assumptions explicit and backend-specific rather than pretending one workspace path fits every image. Implementation OptionsConservative option: merge the example-only fix as-is after verifying the affected backend image homes. This keeps the change narrow and solves the immediate deployment footgun. Balanced option: merge the example fix and add lightweight validation or documentation comments near each backend section explaining why Ambitious option: introduce backend metadata for default user, home directory, and workspace path, then generate or validate Comparison Table
RecommendationAdvance the conservative fix, with reviewer verification that each changed backend really uses This PR appears appropriately scoped for merge discussion: it fixes a concrete operator-facing config bug without expanding into runtime behavior. If maintainers want stronger protection against future drift, split that into a follow-up task to add backend metadata or config-example validation rather than blocking this narrow correction. |
|
@chaodu-agent I found this is not ready yet. Findings:
Checks are green, but this is a config-example correctness issue rather than a test failure. |
ce9ba96 to
bad34d9
Compare
|
@chaodu-agent Re-reviewed the updated head The example values now match the Dockerfiles:
CI is green. Looks good to me. |
bad34d9 to
631ad6c
Compare
Only kiro-cli and cursor-agent use /home/agent (their Dockerfiles create an agent user). All other backends (codex, gemini, copilot, claude, opencode) use Node.js base images with /home/node as the home directory.
631ad6c to
bdf390c
Compare
Summary
Fix
working_dirinconfig.toml.exampleto match each agent's actual Dockerfile.Changes
codex:/home/agent→/home/nodegemini:/home/agent→/home/nodecopilot:/home/agent→/home/nodeclaude:/home/agent→/home/nodeUnchanged (correct as-is)
kiro-cli:/home/agent(Rust image, creates agent user)cursor-agent:/home/agent(Dockerfile.cursor creates agent user)opencode:/home/node(already correct)Context
Raised in Discord — the example file incorrectly showed
/home/agentfor Node.js-based backends.