chore: ignore .claude/ and .claude.local.md#837
Conversation
|
All PRs must reference a prior Discord discussion to ensure community alignment before implementation. Please edit the PR description to include a link like: This PR will be automatically closed in 3 days if the link is not added. |
OpenAB PR ScreeningThis is auto-generated by the OpenAB project-screening flow for context collection and reviewer handoff.
Screening reportposted screening comment: https://github.com//pull/837#issuecomment-4470947037 project action: moved item `PVTI_lADOEFbZWM4BUUALzgs-CAc` to `PR-Screening` in https://github.com/orgs/openabdev/projects/1IntentThis PR is presented as repository hygiene: ignore Claude Code local/session artifacts so developer-specific state does not show up in The diff also includes unrelated changes to FeatClassification: chore, with an unexpected refactor/fix-sized runtime change. The stated behavior is simple: add Who It ServesPrimary beneficiary for the stated change: maintainers and contributors using Claude Code locally. Primary beneficiary for the unstated Rewritten PromptFor the Update the repository ignore rules so Claude Code local artifacts are not tracked. Add If the ACP pool change is intentional, split it into a separate PR with this brief: Refactor Merge PitchThe ignore-rule change is low risk, useful, and mergeable as a tiny maintenance PR. The likely reviewer concern is scope contamination: the PR title and body do not describe the ACP pool changes or the lockfile version bump. Those changes affect runtime behavior and deserve separate review, tests, and a different risk profile. As-is, this should not be merged without either removing the unrelated files or retitling/reworking the PR into a real concurrency change. Best-Practice ComparisonOpenClaw and Hermes Agent are only lightly relevant to the They are relevant to the ACP pool diff. Both patterns favor explicit ownership of execution state, durable state boundaries, and predictable scheduling/session behavior. The proposed per-connection locking moves toward isolated executions by avoiding a single pool-wide lock during connection use, but it needs tests to prove it does not weaken eviction, cleanup, or delivery/session routing guarantees. Hermes-style self-contained runs and atomic persisted state are not directly implemented here. Implementation OptionsOption 1, conservative: keep only the Option 2, balanced: split into two PRs. Merge the Option 3, ambitious: convert this PR into a broader ACP pool concurrency and local-tooling hygiene PR, with title/body updated, tests added for locking/eviction/cleanup behavior, and reviewer attention explicitly requested for runtime semantics. This is slower and probably not worth mixing with ignore rules. Comparison Table
RecommendationUse the balanced path. Ask the author to remove For routing: this item is ready for PR-Screening, but should not be advanced to implementation/review follow-up as a clean |
03c12ec to
5e42854
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5e42854 to
15639ee
Compare
|
Discord Discussion URL: https://discord.com/channels/1491295327620169908/1491365158868619404/1505576771255533628 |
Summary
.claude/and.claude.local.mdto.gitignoreChanges
.gitignore: two new entries to exclude Claude Code session filesThese paths are generated by Claude Code and contain personal session state, worktrees, and local settings. They are developer-specific and should not be committed to the repository.
Test plan
.claude/and.claude.local.mdno longer appear ingit statusoutput after this changeGenerated with Claude Code