docs: add PR lifecycle flow to CONTRIBUTING.md#912
Conversation
|
All PRs must reference a prior Discord discussion to ensure community alignment before implementation. Please edit the PR description to include a link like: This PR will be automatically closed in 3 days if the link is not added. |
OpenAB PR ScreeningThis is auto-generated by the OpenAB project-screening flow for context collection and reviewer handoff.
Screening reportscreened PR #912 and moved project item `PVTI_lADOEFbZWM4BUUALzgtm0KI` to `PR-Screening`.GitHub comment: #912 (comment) IntentDocument how PR lifecycle labels drive maintainer/contributor handoff, stale timing, and auto-close behavior. The operator-visible problem is that contributors and reviewers currently have to infer what FeatDocs work. The PR adds a PR Lifecycle section to Who It ServesPrimary beneficiaries are contributors and reviewers. Maintainers also benefit because the expected review-state machine becomes easier to cite during PR triage. Rewritten PromptUpdate Merge PitchThis should move forward if the documented lifecycle matches the automation currently running on the repo. Risk is low because this is docs-only, but the main reviewer concern is correctness drift: if the stale bot timing or label transitions differ from the docs, this would institutionalize the wrong process. Best-Practice ComparisonOpenClaw and Hermes Agent do not materially apply here. This PR documents GitHub PR lifecycle behavior, not gateway scheduling, durable execution, delivery routing, run persistence, or scheduled agent prompts. The only relevant comparison is procedural: like those systems, the docs should describe the state machine explicitly enough that operators can predict transitions without reading implementation details. Implementation OptionsConservative: merge the docs as-is after verifying the timing and label transitions against the current workflow configuration. Balanced: merge the lifecycle docs, but tighten wording to explicitly name the automation source and clarify whether comments from any user or only the PR author reset the clock. Ambitious: add docs plus a small automation reference link or generated snippet from the workflow source of truth so future stale-policy changes are less likely to drift from Comparison Table
RecommendationUse the balanced path. Confirm the actual stale workflow behavior, then merge with precise wording around who can reset the lifecycle and where the 3-day timers come from. A generated/source-linked policy can be split into a follow-up; it is not necessary to advance this PR. |
What problem does this solve?
Contributors and maintainers need a clear, documented understanding of how PR labels drive the review lifecycle — specifically when PRs go stale and get auto-closed.
At a Glance
Adds an ASCII diagram and label transition table to CONTRIBUTING.md documenting:
pending-contributor→ stale 3 days →closing-soon→ auto-close after 3 more dayspending-maintainerProposed Solution
Append a PR Lifecycle section to the end of CONTRIBUTING.md with:
Validation